fix: omit playwright-core from bundles !! #986
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ export class Bundler { | |||
| write: false, | |||
| minifyWhitespace: true, | |||
| sourcemap: 'inline', | |||
| external: ['@elastic/synthetics'], | |||
| external: ['@elastic/synthetics', 'playwright-core'], | |||
There was a problem hiding this comment.
We could do this, but we would end up creating broken experience for the users if they decided to pull some code from PW.
Allowing this is better for the UX side than having a broken experience. WDYT?
There was a problem hiding this comment.
Better way would be to disallow it as per your PR and have a symbolic link in the Heartbeat side when we set up project monitors so we dont have a broken experience for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have usage of playwright-core in internal monitors, which ends up bundling along.