Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with CLI push after upgrading to 1.14.0 #968

Closed
ameindel opened this issue Oct 18, 2024 · 4 comments · Fixed by #969
Closed

Issue with CLI push after upgrading to 1.14.0 #968

ameindel opened this issue Oct 18, 2024 · 4 comments · Fixed by #969
Assignees
Labels
bug Something isn't working

Comments

@ameindel
Copy link

Hello,

After upgrading from 1.11.1 to 1.14.0, our pipeline encountered an error when attempting to push synthetics to our self-hosted Elastic cluster.

Here is the CLI command used:
npx @elastic/synthetics push --auth [REDACTED] --url https://kibana.our.happy.little.cluster/ --pattern ".titansandbox." --id observability-titan-sandbox --yes

Here is the error I encountered:
TypeError: Cannot read properties of undefined (reading 'length') at validateSettings (C:\Git\observability-synthetics\node_modules\@elastic\synthetics\src\push\index.ts:230:20) at validatePush (C:\Git\observability-synthetics\node_modules\@elastic\synthetics\src\push\index.ts:205:3) at Command.<anonymous> (C:\Git\observability-synthetics\node_modules\@elastic\synthetics\src\cli.ts:216:25) at processTicksAndRejections (node:internal/process/task_queues:95:5)

Here is the suspected breaking change (v1.13.0):
cce2844#diff-b688b09742f54428b94db9d34df92d1190d19c7c153b44c70bcdde60e2a1f1fbR230

src/push/index.ts line 230

Additional info:
For the 'locations' property, it is enforcing ("japan" | "india" | "singapore" | "australia_east" | "united_kingdom" | "germany" | "canada_east" | "brazil" | "us_east" | "us_west")[] | undefined, however, our locations names are customized and do not match with this enforcement.

I'll try downgrading to v1.12.1 as a workaround.

Please let me know if you need any additional information.

Thank you!

@vigneshshanmugam
Copy link
Member

@ameindel Thanks for raising the issue, Could you share your syntheitcs.config.ts file?

however, our locations names are customized and do not match with this enforcement.

Are you running monitors on Globally managed locations or Private locations?

@vigneshshanmugam vigneshshanmugam added the question Further information is requested label Oct 18, 2024
@vigneshshanmugam
Copy link
Member

I was able to reproduce the issue by passing only the private location option. Thanks for raising it.

@vigneshshanmugam vigneshshanmugam added bug Something isn't working and removed question Further information is requested labels Oct 18, 2024
@vigneshshanmugam vigneshshanmugam self-assigned this Oct 18, 2024
@ameindel
Copy link
Author

Thanks for the quick response, @vigneshshanmugam. We're running on Private Locations. Please let me know if you still need me to share the synthetics.config.ts file.

@vigneshshanmugam
Copy link
Member

Np, all good, the issue has been resolved. We will do a release next week. Thanks again for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants