-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for browser & context options via config #299
Comments
All these options should be overridable from heartbeat via flags etc. |
We also need to think about the fleet UI for them |
Was thinking to mirror them in heartbeat.yml, something like |
I agree, having these options available to pass in gives us the flexibility to add config options as and when supported by newer versions of Playwright, without having to support them with specific params in HB/Synthetics. Does it makes sense to initially have these as free form configuration options in the Fleet UI, and then add specific UI (e.g. checkbox) for some of these (e.g. ignore HTTPS errors, or device emulation), or will this create too much of a migration problem (mixed up config JSON and 'tick boxes'? Maybe they are available like params are if you use heartbeat.yml in the first instance (nothing in Fleet), and then we add specific capabilities into the Fleet UI over time (e.g. device emulation etc.), as we view that configuration in the result UI as well (e.g. show the device type against the result). /cc @drewpost @liciavale |
There are lot of ways we can configure the Playwright Browser and the context that is used to creating page objects in Playwright.
Browser launch options -
chromium.launch(options)
- https://playwright.dev/docs/api/class-browsertype?_highlight=launch#browsertypelaunchoptionstimeouts, headless, sandbox, slowMo
and alsobrowserName
in the future - Add slowMo flag for playwright #169Browser Context options -
browser.newContext(options)
- https://playwright.dev/docs/api/class-browser#browsernewcontextoptionsignoreHttpsError, Throttling, Offline emulation, device emulation etc
- AddignoreHTTPSError
option on journeys and CLI #171 Emulate device type (UA String and Viewport) #209To make it easier for users, We can introduce new flags in the
synthetics.config.ts
instead of adding CLI option for each and every config out there in the playwright.This Proposal is as allow configuring
browser
andcontext
options to the synthetic config in addition to the existingparams
support.We could also merge them under
playwrightOptions
instead of separating them out and provide a validation that allowss only a restrictive list of options to keep things cleaner as well.@andrewvc @paulb-elastic Thoughts?
The text was updated successfully, but these errors were encountered: