Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use network events from PW instead of using CDPSession #287

Closed
vigneshshanmugam opened this issue May 25, 2021 · 3 comments · Fixed by #372
Closed

Use network events from PW instead of using CDPSession #287

vigneshshanmugam opened this issue May 25, 2021 · 3 comments · Fixed by #372
Assignees
Labels
enhancement New feature or request

Comments

@vigneshshanmugam
Copy link
Member

Currently, we use own internal CDP session for monitoring network info and construct the network waterfall. It works good, but requires a heavy work when we want to capture network events from popups and other tabs.

We uses this approach as playwright previous did not have any HAR tracer and used page level network events which is pretty much same as ours. Now PW exposes all these events from the browser context microsoft/playwright#6370 which means we can extract all the network information for cross pages, popups and windows relying on the same.

However, we need to do this after a new release of PW is published including the network events changes and also the security details.

@vigneshshanmugam vigneshshanmugam added the enhancement New feature or request label May 25, 2021
@vigneshshanmugam
Copy link
Member Author

However, we need to do this after a new release of PW is published including the network events changes and also the security details.

1.12.0 is published, this can be picked up now - https://github.com/microsoft/playwright/releases/tag/v1.12.0

@vigneshshanmugam
Copy link
Member Author

Need both of these issues to be addressed in PW to keep the parity with directly hooking in to CDP

@shahzad31
Copy link
Contributor

Post FF Testing

Network data still looks good
image

@zube zube bot removed the [zube]: Done label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants