Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag to control filmstrip image capture #143

Closed
2 tasks
paulb-elastic opened this issue Nov 19, 2020 · 4 comments · Fixed by #121
Closed
2 tasks

Feature flag to control filmstrip image capture #143

paulb-elastic opened this issue Nov 19, 2020 · 4 comments · Fixed by #121
Labels

Comments

@paulb-elastic
Copy link
Contributor

Until filmstrips are implemented (elastic/kibana#83816), we want to change the default behaviour of the Synthetic Agent to stop capturing filmstrip images, to avoid any impact of them, or incorrect timestamps. Similarly, we want the ability to do filmstrip capture testing, so will be able to switch them on with a feature flag.

Acceptance criteria

  • By default, the Synthetics Agent will not capture filmstrip images
  • There is a configuration option that, when enabled, will make the Synthetics Agent capture filmstrip images (in the same way that it does currently)
@hmdhk
Copy link
Contributor

hmdhk commented Nov 19, 2020

To clarify, we currently have the screenshots option that is used for both step screenshots and filmstrip, so we need to separate these.

@paulb-elastic
Copy link
Contributor Author

Thanks @jahtalab, didn't realise it was the same process used for both (I thought we captured a screen shot on step complete).

That's correct, irrespective of this feature, we still need to have final screen shot for all steps, as we do now.

@vigneshshanmugam
Copy link
Member

This is already done btw - #121 😄

@hmdhk
Copy link
Contributor

hmdhk commented Nov 23, 2020

Thanks @vigneshshanmugam , I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants