Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for useRecordingContext #364

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

justinkambic
Copy link
Contributor

Summary

Related to #264. Adds test for useRecordingContext.

Implementation details

Adds unit tests.

How to validate this change

If the test looks like it makes sense and it is passing CI no further testing needed.

@justinkambic justinkambic added the test:unit Pertains to unit testing label Jan 31, 2023
@justinkambic justinkambic self-assigned this Jan 31, 2023
@justinkambic justinkambic force-pushed the 264/use-recording-context branch from bee4328 to 4f54c4f Compare January 31, 2023 17:03
@apmmachine
Copy link
Contributor

apmmachine commented Jan 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-31T17:04:19.915+0000

  • Duration: 3 min 50 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test all : Re-trigger the build for all the stages.

Copy link
Contributor

@kyungeunni kyungeunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinkambic justinkambic merged commit fe535e1 into elastic:main Feb 1, 2023
@justinkambic justinkambic deleted the 264/use-recording-context branch February 1, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:unit Pertains to unit testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants