Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for useGlobalToasts #359

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

justinkambic
Copy link
Contributor

Summary

NOTE TO REVIEWERS: This should not be reviewed until #353 is merged.

Related to #264. Adds test for useGlobalToasts.

Implementation details

Adds unit tests.

How to validate this change

If the test looks like it makes sense and it is passing CI no further testing needed.

@justinkambic justinkambic added the test:unit Pertains to unit testing label Jan 26, 2023
@justinkambic justinkambic self-assigned this Jan 26, 2023
@apmmachine
Copy link
Contributor

apmmachine commented Jan 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-31T16:58:40.829+0000

  • Duration: 3 min 42 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test all : Re-trigger the build for all the stages.

Copy link
Contributor

@kyungeunni kyungeunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all these unit tests, @justinkambic! I don't think I have push permission to your branches so I couldn't rebase & merge all the opened PRs myself. I assume the tests for this PR failed because the dependent commits aren't included yet?

Feel free to bulk-merge them 😎

@justinkambic justinkambic force-pushed the 264/use-global-toasts-tests branch from 1101e3b to 791f036 Compare January 31, 2023 15:57
@justinkambic justinkambic force-pushed the 264/use-global-toasts-tests branch from 791f036 to 1433f2b Compare January 31, 2023 16:58
@justinkambic
Copy link
Contributor Author

I assume the tests for this PR failed because the dependent commits aren't included yet?

Actually not sure why that happened, but it has passed numerous runs now, so I will go ahead and merge it.

@justinkambic justinkambic merged commit e7d0cda into elastic:main Jan 31, 2023
@justinkambic justinkambic deleted the 264/use-global-toasts-tests branch January 31, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:unit Pertains to unit testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants