Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Elastic Playwright fork to later version of official Playwright #262

Closed
3 tasks done
Tracked by #250
justinkambic opened this issue Jun 1, 2022 · 0 comments · Fixed by #285
Closed
3 tasks done
Tracked by #250

Migrate Elastic Playwright fork to later version of official Playwright #262

justinkambic opened this issue Jun 1, 2022 · 0 comments · Fixed by #285
Assignees
Labels

Comments

@justinkambic
Copy link
Contributor

justinkambic commented Jun 1, 2022

The version of Playwright we reference today is very out of date. Before we can make the Recorder GA, we are going to need to update Elastic's Playwright fork to the latest version referenced by Synthetics. Once we do this, we unblock ourselves from upgrading Playwright, Elastic Synthetics, etc.

This is important from a feature perspective, as well as a security standpoint. We can't make the Recorder GA until we're able to respond to emergency patches to all of its dependencies, including Synthetics/Playwright. Without accomplishing this upgrade, we will not be able to quickly patch our software in the event of a serious security issue, and thus we're not a candidate for production use until we have that capability.

TODO

  • Update @elastic/playwright to latest upstream:main, or fresh fork the repo
  • Apply the patch we have in separate-recorder branch
  • Use latest @elastic/synthetics in recorder
@justinkambic justinkambic changed the title Update Script Recorder to the latest PW version we have in Synthetics Migrate Elastic Playwright fork to later version of official Playwright Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants