Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FacetContainer: show prop should not apply to all facets #570

Open
mauricesnip opened this issue Jun 24, 2021 · 2 comments
Open

FacetContainer: show prop should not apply to all facets #570

mauricesnip opened this issue Jun 24, 2021 · 2 comments

Comments

@mauricesnip
Copy link

mauricesnip commented Jun 24, 2021

The show prop is hardcoded in FacetContainer, so every facet (View) gets a sliced facetValues array passed as options prop. This is not desirable for facets like SingleSelectFacet, which do not have a mechanism for showing more options by clicking on a "More" link for example. Should the show prop be taken care of by the individual facet components? Or maybe a wider opt-in/opt-out feature for slicing facetValues?

Gitter references

Addendum
Note that you can work around this "issue" by simply setting show={9999} for example. Although in my opinion, it's not that elegant.

@botelastic
Copy link

botelastic bot commented Aug 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

@botelastic botelastic bot added the wontfix This will not be worked on label Aug 23, 2021
@JasonStoltz
Copy link
Member

willfix

@botelastic botelastic bot removed the wontfix This will not be worked on label Aug 23, 2021
@JasonStoltz JasonStoltz added pinned bug Something isn't working labels Oct 12, 2021
@JasonStoltz JasonStoltz added enhancement and removed bug Something isn't working labels Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants