Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillReceiveProps has been renamed, and is not recommended for use. #463

Closed
philwilliammee opened this issue Feb 14, 2020 · 3 comments
Labels
wontfix This will not be worked on

Comments

@philwilliammee
Copy link

in development build I get the warning. I haven't tracked down exactly where its coming from it might be from my webpack compiler.
componentWillReceiveProps has been renamed, and is not recommended for use.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
@JasonStoltz
Copy link
Member

Interesting, it must be from a dependency, I don't believe we use that anywhere.

@philwilliammee
Copy link
Author

philwilliammee commented Feb 16, 2020

@JasonStoltz yep it looks like the warning is coming from the dependency react-select.

The warning message also says:
Please update the following components: Select

$ npm ls react-select
`-- @elastic/[email protected]
  `-- [email protected] 

It is referenced in multiple issues. JedWatson/react-select#3720 and JedWatson/react-select#3745

It looks like the latest release 3.0.8 does not have a fix for this open issue.

@JasonStoltz JasonStoltz pinned this issue Mar 10, 2020
@JasonStoltz JasonStoltz unpinned this issue Mar 10, 2020
@botelastic
Copy link

botelastic bot commented Apr 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is this issue still important to you? If so, please leave a comment and let us know. As always, thank you for your contributions.

@botelastic botelastic bot added the wontfix This will not be worked on label Apr 16, 2020
@botelastic botelastic bot closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants