Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server certificate validation in client #17

Open
urso opened this issue Sep 23, 2015 · 0 comments
Open

Improve server certificate validation in client #17

urso opened this issue Sep 23, 2015 · 0 comments

Comments

@urso
Copy link

urso commented Sep 23, 2015

The logstash-forwarder and filebeat certificate validation will also check the server certificate domain name. For openssl this check must be done by the library user after connecting to a server.

For FQDN validation of server certificate the client should use the servers certificate after the handshake (connect) to search for the domain name in the X.509 extension fields with fallback to the commonName field. This check is required to prevent potential man-in-the middle attacks.

The ruby openssl module already provides post_connection_check. But post_connection_check must be called by developer.

It should be possible to disable this check for testing purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants