From 215b34df3450eef93c912e668d459c8ad837cce8 Mon Sep 17 00:00:00 2001 From: Suyog Rao Date: Wed, 18 May 2016 17:14:53 -0700 Subject: [PATCH 1/3] Move Contributors for more visibility --- .github/CONTRIBUTING.md => CONTRIBUTING.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) rename .github/CONTRIBUTING.md => CONTRIBUTING.md (96%) diff --git a/.github/CONTRIBUTING.md b/CONTRIBUTING.md similarity index 96% rename from .github/CONTRIBUTING.md rename to CONTRIBUTING.md index d325328823b..029837cf2df 100644 --- a/.github/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,7 @@ That said, some basic guidelines, which you are free to ignore :) ## Want to learn? -Want to lurk about and see what others are doing with Logstash? +Want to lurk about and see what others are doing with Logstash? * The irc channel (#logstash on irc.freenode.org) is a good place for this * The [forum](https://discuss.elastic.co/c/logstash) is also @@ -18,7 +18,7 @@ Want to lurk about and see what others are doing with Logstash? ## Got Questions? -Have a problem you want Logstash to solve for you? +Have a problem you want Logstash to solve for you? * You can ask a question in the [forum](https://discuss.elastic.co/c/logstash) * Alternately, you are welcome to join the IRC channel #logstash on @@ -61,5 +61,3 @@ Check our [documentation](https://www.elastic.co/guide/en/logstash/current/contr request](https://help.github.com/articles/using-pull-requests). In the pull request, describe what your changes do and mention any bugs/issues related to the pull request. - - From c29db3e299e84f076530e84d02a987a73bda39b6 Mon Sep 17 00:00:00 2001 From: Suyog Rao Date: Wed, 18 May 2016 18:25:01 -0700 Subject: [PATCH 2/3] Add priority labels --- CONTRIBUTING.md | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 029837cf2df..9b301abac22 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,12 +36,32 @@ If you think you found a bug, it probably is a bug. * If it is specific to a plugin, please file it in the respective repository under [logstash-plugins](https://github.com/logstash-plugins) * or ask the [forum](https://discuss.elastic.co/c/logstash). +## Issue Prioritization +The Logstash team takes time to digest, consider solutions, and weigh applicability of issues to both the broad +Logstash user base and our own goals for the project. Through this process, we assign issues a priority using GitHub +labels. Below is a description of priority labels. + +* P1: A high priority issue that affects almost all Logstash users. Bugs that would cause data loss, security +issues, and features that would vastly improve the user experience for everyone. Workarounds for P1s +generally don’t exist without a code change. +* P2: A broadly applicable, high visibility issue that enhances Logstash usability for a majority of users. +* P3: Nice-to-have bug fixes or functionality. Workarounds for P3s generally exist. +* P4: Anything not in above, catch-all label. + # Contributing Documentation and Code Changes -If you have a bugfix or new feature that you would like to contribute to -logstash, and you think it will take more than a few minutes to produce the fix -(ie; write code), it is worth discussing the change with the Logstash users and developers first! You can reach us via [GitHub](https://github.com/elastic/logstash/issues), the [forum](https://discuss.elastic.co/c/logstash), or via IRC (#logstash on freenode irc) -Please note that Pull Requests without tests will not be merged. If you would like to contribute but do not have experience with writing tests, please ping us on IRC/forum or create a PR and ask our help. +If you have a bugfix or new feature that you would like to contribute to Logstash, and you think it will take +more than a few minutes to produce the fix (ie; write code), it is worth discussing the change with the Logstash +users and developers first! You can reach us via [GitHub](https://github.com/elastic/logstash/issues), the [forum](https://discuss.elastic.co/c/logstash), or via IRC (#logstash on freenode irc) +Please note that Pull Requests without tests will not be merged. If you would like to contribute but do not have +experience with writing tests, please ping us on IRC/forum or create a PR and ask our help. + +If you would like to contribute to Logstash, but don't know where to start, you can use the GitHub labels "adoptme" +and "low hanging fruit". Issues marked with these labels are relatively easy, and provides a good starting +point to contribute to Logstash. + +See: https://github.com/elastic/logstash/labels/adoptme +https://github.com/elastic/logstash/labels/low%20hanging%20fruit ## Contributing to plugins From bdddab99a9d1807a46d1a6176853b1d5cb801edc Mon Sep 17 00:00:00 2001 From: Suyog Rao Date: Fri, 20 May 2016 09:41:41 -0700 Subject: [PATCH 3/3] Fix P1 definition to include test failures --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9b301abac22..e9eab8029ac 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -42,8 +42,8 @@ Logstash user base and our own goals for the project. Through this process, we a labels. Below is a description of priority labels. * P1: A high priority issue that affects almost all Logstash users. Bugs that would cause data loss, security -issues, and features that would vastly improve the user experience for everyone. Workarounds for P1s -generally don’t exist without a code change. +issues and test failures. Workarounds for P1s generally don’t exist without a code change. A P1 issue is usually +stop the world kinda scenario, so we need to make sure P1s are properly triaged and being worked upon. * P2: A broadly applicable, high visibility issue that enhances Logstash usability for a majority of users. * P3: Nice-to-have bug fixes or functionality. Workarounds for P3s generally exist. * P4: Anything not in above, catch-all label.