Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Improve workpad schema validation #97838

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Apr 21, 2021

Fixes #23968

This adds a bit more to our workpad schema validation to make sure there are no dupe ids used between pages or elements, which causes some issues between trying to update elements or navigate between pages or anything like that where a lookup by id could find dupes.

Attached is a workpad that has dupe page ids, and you should be able to manipulate the element ids as well to test that

canvas-workpad-My Canvas Workpad-workpad-4fd55cfb-3113-43f0-9916-d910fd0d82b7.json.txt

@crob611 crob611 requested a review from a team as a code owner April 21, 2021 15:33
@crob611 crob611 added Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.13.0 v8.0.0 labels Apr 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@crob611 crob611 added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 21, 2021
@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
@crob611
Copy link
Contributor Author

crob611 commented Oct 5, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 added the v8.1.0 label Nov 4, 2021
@crob611
Copy link
Contributor Author

crob611 commented Nov 4, 2021

@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Nov 15, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #1 / Monitoring app Elasticsearch nodes listing mb with offline node should sort by name

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
@crob611 crob611 removed the v7.16.0 label Nov 15, 2021
@crob611 crob611 merged commit 8ae410e into elastic:main Nov 15, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 15, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Corey Robertson <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 16, 2021
…igrate-away-from-injected-css-js

* 'main' of github.com:elastic/kibana: (221 commits)
  [Reporting] Add log level to config (elastic#118319)
  [Metrics UI] Skip failing waffle chart color palette test (elastic#118527)
  [APM] chore: Unify naming of 'apm/scripts/**/*' with snake_case (elastic#118328)
  skip flaky suites (elastic#99581, elastic#118356, elastic#118474)
  [Alerting] Initial implementation of alerting task `cancel()` (elastic#114289)
  chore(NA): creates pkg_npm_types bazel rule (elastic#116465)
  skip flaky suite (elastic#116892)
  Bump chromedriver to 95.0.0 (elastic#116724)
  [Data visualizer] Improve design of expanded rows (elastic#118125)
  [APM] prefer ECS field names for HTTP and URL (elastic#118485)
  Update query_debugging_in_development_and_production.md (elastic#118491)
  [Uptime] adjust Elastic Synthetics integration functional tests (elastic#118163)
  [kbn/rule-data-utils] add submodules and require public use them (elastic#117963)
  [DOCS] Refresh APM correlation screenshots (elastic#116723) (elastic#118577)
  Handles ns to ms conversion for event loop delay metrics (elastic#118447)
  [Cases] Rename functional tests folder (elastic#118490)
  dummy commit
  skip flaky suite (elastic#118593)
  Improve workpad schema validation (elastic#97838)
  skip flaky suite (elastic#118584)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 19, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate uploaded workpad JSON
7 participants