From 3560a93f1a27def9eb437dc7b970a5841a4820a3 Mon Sep 17 00:00:00 2001
From: Justin Kambic <justin.kambic@elastic.co>
Date: Thu, 21 Jan 2021 14:08:52 -0500
Subject: [PATCH] Rename conversion function, extract to module scope and add
 tests.

---
 .../server/lib/requests/get_network_events.test.ts   | 12 +++++++++++-
 .../uptime/server/lib/requests/get_network_events.ts | 12 +++++++-----
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/x-pack/plugins/uptime/server/lib/requests/get_network_events.test.ts b/x-pack/plugins/uptime/server/lib/requests/get_network_events.test.ts
index e8618fabc4cc..827b5df2386a 100644
--- a/x-pack/plugins/uptime/server/lib/requests/get_network_events.test.ts
+++ b/x-pack/plugins/uptime/server/lib/requests/get_network_events.test.ts
@@ -5,9 +5,19 @@
  */
 
 import { getUptimeESMockClient } from './helper';
-import { getNetworkEvents } from './get_network_events';
+import { getNetworkEvents, secondsToMillis } from './get_network_events';
 
 describe('getNetworkEvents', () => {
+  describe('secondsToMillis conversion', () => {
+    it('returns -1 for -1 value', () => {
+      expect(secondsToMillis(-1)).toBe(-1);
+    });
+
+    it('returns a value of seconds as milliseconds', () => {
+      expect(secondsToMillis(10)).toBe(10_000);
+    });
+  });
+
   let mockHits: any;
 
   beforeEach(() => {
diff --git a/x-pack/plugins/uptime/server/lib/requests/get_network_events.ts b/x-pack/plugins/uptime/server/lib/requests/get_network_events.ts
index 1353175a8f94..f39456be30d8 100644
--- a/x-pack/plugins/uptime/server/lib/requests/get_network_events.ts
+++ b/x-pack/plugins/uptime/server/lib/requests/get_network_events.ts
@@ -12,6 +12,10 @@ interface GetNetworkEventsParams {
   stepIndex: string;
 }
 
+export const secondsToMillis = (seconds: number) =>
+  // -1 is a special case where a value was unavailable
+  seconds === -1 ? -1 : seconds * 1000;
+
 export const getNetworkEvents: UMElasticsearchQueryFn<
   GetNetworkEventsParams,
   NetworkEvent[]
@@ -34,14 +38,12 @@ export const getNetworkEvents: UMElasticsearchQueryFn<
 
   const { body: result } = await uptimeEsClient.search({ body: params });
 
-  const microToMillis = (micro: number): number => (micro === -1 ? -1 : micro * 1000);
-
   return result.hits.hits.map<NetworkEvent>((event: any) => {
-    const requestSentTime = microToMillis(event._source.synthetics.payload.request_sent_time);
-    const loadEndTime = microToMillis(event._source.synthetics.payload.load_end_time);
+    const requestSentTime = secondsToMillis(event._source.synthetics.payload.request_sent_time);
+    const loadEndTime = secondsToMillis(event._source.synthetics.payload.load_end_time);
     const requestStartTime =
       event._source.synthetics.payload.response && event._source.synthetics.payload.response.timing
-        ? microToMillis(event._source.synthetics.payload.response.timing.request_time)
+        ? secondsToMillis(event._source.synthetics.payload.response.timing.request_time)
         : undefined;
 
     return {