Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Restore a11y flacky tests #88954

Merged
merged 2 commits into from
Jan 25, 2021
Merged

[Lens] Restore a11y flacky tests #88954

merged 2 commits into from
Jan 25, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 21, 2021 •
edited by spalger
Loading

Summary

Fixes #88929
Fixes #88927
Fixes #88926

Some were giving flaky results due to the "no data" popup in the TimeRange filter input.
This PR should address that.

Flaky runner results with 100 runs: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1134/

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.12.0 labels Jan 21, 2021
@dej611 dej611 requested a review from spalger January 21, 2021 11:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@dej611
Copy link
Contributor Author

dej611 commented Jan 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 99ffbbe into elastic:master Jan 25, 2021
@dej611 dej611 deleted the fix/88929 branch January 25, 2021 13:46
@dej611 dej611 mentioned this pull request Jan 26, 2021
Merged
dej611 added a commit to dej611/kibana that referenced this pull request Jan 26, 2021
@dej611 @kibanamachine
[Lens] Restore a11y flacky tests (elastic#88954)
ff69eff 
Co-authored-by: Kibana Machine <[email protected]>
dej611 added a commit that referenced this pull request Jan 27, 2021
@dej611 @kibanamachine
[7.x] [Lens] Restore a11y flacky tests (#88954) (#89335)
a893d34 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@dej611 @elasticmachine @kibanamachine @spalger @flash1293