-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILM] Searchable snapshot default "enabled" on cloud #88582
[ILM] Searchable snapshot default "enabled" on cloud #88582
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodesByRoles: { data: ['123'] }, | ||
}); | ||
httpRequestsMockHelpers.setListSnapshotRepos({ repositories: ['found-snapshots'] }); | ||
describe('new policy', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the test file is called edit_policy.test.ts
. I'm not familiar with all the test cases here, but perhaps it should be renamed if we're testing both new and existing policies here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good point. For now this lines up with the component/section name of the plugin. The semantics are not quite right, if you think it is worth it, would you mind opening an issue for this change? It seems like something that needs a bit of thought as to what it should be called and whether any restructuring/refactoring is required.
Thanks for the review @alisonelizabeth !
Right, on-prem the field will not autocomplete to a non-existent snapshot repository. For the sake of the screenshot I hid the warning 😄 |
* default searchable snapshot to enabled on cloud when creating a new policy * added test for searchable snapshot on new policy on cloud
* default searchable snapshot to enabled on cloud when creating a new policy * added test for searchable snapshot on new policy on cloud
Summary
Adds logic for turning searchable snapshots on by default on cloud.
How to test
xpack.cloud.id
andxpack.cloud.deploymentUrl
inkibana.dev.yml
found-snapshots
for the snapshot repositoryxpack.cloud.id
andxpack.cloud.deploymentUrl
unset (so non-cloud deployment)Checklist