From 86806fa687dd19345a4ba3f48c3b98c2b402e9d1 Mon Sep 17 00:00:00 2001 From: Uladzislau Lasitsa Date: Fri, 13 Nov 2020 12:37:25 +0300 Subject: [PATCH 1/4] Added deprecation for visualization:colorMapping --- docs/management/advanced-options.asciidoc | 1 + src/plugins/charts/server/plugin.ts | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc index dbac6997ff43..54ca7a5a17ef 100644 --- a/docs/management/advanced-options.asciidoc +++ b/docs/management/advanced-options.asciidoc @@ -454,6 +454,7 @@ of buckets to try to represent. [horizontal] [[visualization-colormapping]]`visualization:colorMapping`:: +**Deprecated** Maps values to specified colors in visualizations. [[visualization-dimmingopacity]]`visualization:dimmingOpacity`:: diff --git a/src/plugins/charts/server/plugin.ts b/src/plugins/charts/server/plugin.ts index 0123459bd25d..35468a71608c 100644 --- a/src/plugins/charts/server/plugin.ts +++ b/src/plugins/charts/server/plugin.ts @@ -43,6 +43,15 @@ export class ChartsServerPlugin implements Plugin { description: i18n.translate('charts.advancedSettings.visualization.colorMappingText', { defaultMessage: 'Maps values to specified colors within visualizations', }), + deprecation: { + message: i18n.translate( + 'charts.advancedSettings.visualization.colorMappingTextDeprecation', + { + defaultMessage: 'This setting is deprecated.', + } + ), + docLinksKey: 'visualizationSettings', + }, category: ['visualization'], schema: schema.string(), }, From ad796aaa688bb7e8e9637772ec0c79e607c6d9c3 Mon Sep 17 00:00:00 2001 From: Uladzislau Lasitsa Date: Fri, 20 Nov 2020 10:31:22 +0300 Subject: [PATCH 2/4] Update text of deprecation --- docs/management/advanced-options.asciidoc | 3 ++- src/plugins/charts/server/plugin.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc index 54ca7a5a17ef..c13754056143 100644 --- a/docs/management/advanced-options.asciidoc +++ b/docs/management/advanced-options.asciidoc @@ -454,7 +454,8 @@ of buckets to try to represent. [horizontal] [[visualization-colormapping]]`visualization:colorMapping`:: -**Deprecated** +**This setting is deprecated and will not be supported as of 8.0. +Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.** Maps values to specified colors in visualizations. [[visualization-dimmingopacity]]`visualization:dimmingOpacity`:: diff --git a/src/plugins/charts/server/plugin.ts b/src/plugins/charts/server/plugin.ts index 35468a71608c..cc1ca31e0abc 100644 --- a/src/plugins/charts/server/plugin.ts +++ b/src/plugins/charts/server/plugin.ts @@ -47,7 +47,8 @@ export class ChartsServerPlugin implements Plugin { message: i18n.translate( 'charts.advancedSettings.visualization.colorMappingTextDeprecation', { - defaultMessage: 'This setting is deprecated.', + defaultMessage: + 'This setting is deprecated and will not be supported as of 8.0. Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.', } ), docLinksKey: 'visualizationSettings', From ebea2d9b350943e0cd1b7819ed72d0bcdff6b725 Mon Sep 17 00:00:00 2001 From: Uladzislau Lasitsa Date: Fri, 20 Nov 2020 13:49:02 +0300 Subject: [PATCH 3/4] Update message --- docs/management/advanced-options.asciidoc | 5 ++--- src/plugins/charts/server/plugin.ts | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/management/advanced-options.asciidoc b/docs/management/advanced-options.asciidoc index c13754056143..6244a43b54f7 100644 --- a/docs/management/advanced-options.asciidoc +++ b/docs/management/advanced-options.asciidoc @@ -454,9 +454,8 @@ of buckets to try to represent. [horizontal] [[visualization-colormapping]]`visualization:colorMapping`:: -**This setting is deprecated and will not be supported as of 8.0. -Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.** -Maps values to specified colors in visualizations. +**This setting is deprecated and will not be supported as of 8.0.** +Maps values to specific colors in *Visualize* charts and *TSVB*. This setting does not apply to *Lens*. [[visualization-dimmingopacity]]`visualization:dimmingOpacity`:: The opacity of the chart items that are dimmed when highlighting another element diff --git a/src/plugins/charts/server/plugin.ts b/src/plugins/charts/server/plugin.ts index cc1ca31e0abc..2a9b82afefc9 100644 --- a/src/plugins/charts/server/plugin.ts +++ b/src/plugins/charts/server/plugin.ts @@ -41,14 +41,14 @@ export class ChartsServerPlugin implements Plugin { }), type: 'json', description: i18n.translate('charts.advancedSettings.visualization.colorMappingText', { - defaultMessage: 'Maps values to specified colors within visualizations', + defaultMessage: + 'Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.', }), deprecation: { message: i18n.translate( 'charts.advancedSettings.visualization.colorMappingTextDeprecation', { - defaultMessage: - 'This setting is deprecated and will not be supported as of 8.0. Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.', + defaultMessage: 'This setting is deprecated and will not be supported as of 8.0.', } ), docLinksKey: 'visualizationSettings', From b09d5d5eb4af004cb7d1dd5fe5caf7dcd705cb42 Mon Sep 17 00:00:00 2001 From: Uladzislau Lasitsa Date: Fri, 20 Nov 2020 16:48:25 +0300 Subject: [PATCH 4/4] Delete from translations for re-translation --- x-pack/plugins/translations/translations/ja-JP.json | 1 - x-pack/plugins/translations/translations/zh-CN.json | 1 - 2 files changed, 2 deletions(-) diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index beb6325e4fec..4c60a94450af 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -240,7 +240,6 @@ "apmOss.tutorial.startServer.title": "APM Server の起動", "apmOss.tutorial.windowsServerInstructions.textPost": "注:システムでスクリプトの実行が無効な場合、スクリプトを実行するために現在のセッションの実行ポリシーの設定が必要となります。例: {command}。", "apmOss.tutorial.windowsServerInstructions.textPre": "1.[ダウンロードページ]({downloadPageLink}) から APM Server Windows zip ファイルをダウンロードします。\n2.zip ファイルの内容を {zipFileExtractFolder} に抽出します。\n3.「{apmServerDirectory} ディレクトリの名前を「APM-Server」に変更します。\n4.管理者として PowerShell プロンプトを開きます (PowerShell アイコンを右クリックして「管理者として実行」を選択します)。Windows XP をご使用の場合、PowerShell のダウンロードとインストールが必要な場合があります。\n5.PowerShellプロンプトで次のコマンドを実行し、APM ServerをWindowsサービスとしてインストールします。", - "charts.advancedSettings.visualization.colorMappingText": "ビジュアライゼーション内の特定の色のマップ値です", "charts.advancedSettings.visualization.colorMappingTitle": "カラーマッピング", "charts.colormaps.bluesText": "青", "charts.colormaps.greensText": "緑", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index d069d43de740..dc589b085fae 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -240,7 +240,6 @@ "apmOss.tutorial.startServer.title": "启动 APM Server", "apmOss.tutorial.windowsServerInstructions.textPost": "注意：如果您的系统禁用了脚本执行，则需要为当前会话设置执行策略，以允许脚本运行。示例：{command}。", "apmOss.tutorial.windowsServerInstructions.textPre": "1.从[下载页面]({downloadPageLink})下载 APM Server Windows zip 文件。\n2.将 zip 文件的内容解压缩到 {zipFileExtractFolder}。\n3.将 {apmServerDirectory} 目录重命名为 `APM-Server`。\n4.以管理员身份打开 PowerShell 提示符（右键单击 PowerShell 图标，然后选择**以管理员身份运行**）。如果您正在运行 Windows XP，您可能需要下载并安装 PowerShell。\n5.从 PowerShell 提示符处，运行以下命令以将 APM Server 安装为 Windows 服务：", - "charts.advancedSettings.visualization.colorMappingText": "将值映射到可视化内的指定颜色", "charts.advancedSettings.visualization.colorMappingTitle": "颜色映射", "charts.colormaps.bluesText": "蓝色", "charts.colormaps.greensText": "绿色",