Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote clusters] Refactor component integration tests #82517

Merged
merged 2 commits into from
Nov 5, 2020
Merged

[Remote clusters] Refactor component integration tests #82517

merged 2 commits into from
Nov 5, 2020

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Nov 3, 2020 •
edited
Loading

This PR removes the use of waitFor() and nextTick() in the remote clusters component integration tests.

Fixes #82242

@alisonelizabeth alisonelizabeth added chore Feature:CCR and Remote Clusters v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 3, 2020
@alisonelizabeth alisonelizabeth force-pushed the remote_clusters/refactor_tests branch from 41ed88c to 135402f Compare November 4, 2020 02:17
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth marked this pull request as ready for review November 4, 2020 13:14
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner November 4, 2020 13:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga
sebelga approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making those changes 👍

@alisonelizabeth alisonelizabeth merged commit ea0736e into elastic:master Nov 5, 2020
@alisonelizabeth alisonelizabeth deleted the remote_clusters/refactor_tests branch November 5, 2020 14:01
@alisonelizabeth alisonelizabeth mentioned this pull request Nov 5, 2020
Merged
alisonelizabeth added a commit that referenced this pull request Nov 5, 2020
@alisonelizabeth
[Remote clusters] Refactor tests (#82517) (#82718)
5fbe4f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
chore Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @sebelga