Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Use base path for screenshot url #81930

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #81602

Use base path for screenshot url, also removed extra spacing between steps to conserve vertical scroll space.

@shahzad31 shahzad31 requested a review from a team as a code owner October 28, 2020 17:57
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0 labels Oct 28, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
uptime 1.1MB 1.1MB +136.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 requested a review from Kerry350 October 29, 2020 12:54
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime UI] Synthetics step images don't work with a basePath
4 participants