Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Updating 'Add new' wording #80509

Merged
merged 4 commits into from
Oct 16, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,16 @@ export const EmailParamsFields = ({
{!addCC ? (
<EuiButtonEmpty size="xs" onClick={() => setAddCC(true)}>
<FormattedMessage
defaultMessage="Add Cc"
defaultMessage="Cc"
id="xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addCcButton"
/>
</EuiButtonEmpty>
) : null}
{!addBCC ? (
<EuiButtonEmpty size="xs" onClick={() => setAddBCC(true)}>
<FormattedMessage
defaultMessage="{titleBcc}"
defaultMessage="Bcc"
id="xpack.triggersActionsUI.sections.builtinActionTypes.emailAction.addBccButton"
values={{ titleBcc: !addCC ? '/ Bcc' : 'Add Bcc' }}
/>
</EuiButtonEmpty>
) : null}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ describe('action_form', () => {
`);
});

it('does not render "Add new" button for preconfigured only action type', async () => {
it('does not render "Add connector" button for preconfigured only action type', async () => {
await setup();
const actionOption = wrapper.find('[data-test-subj="preconfigured-ActionTypeSelectOption"]');
actionOption.first().simulate('click');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export const ActionForm = ({
}}
>
<FormattedMessage
defaultMessage="Add new"
defaultMessage="Add connector"
id="xpack.triggersActionsUI.sections.alertForm.addNewConnectorEmptyButton"
/>
</EuiButtonEmpty>
Expand Down