Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Added an EuiEmptyState to Credentials page #2 #80034

Merged
merged 5 commits into from
Oct 19, 2020
Merged

[Enterprise Search] Added an EuiEmptyState to Credentials page #2 #80034

merged 5 commits into from
Oct 19, 2020

Conversation

JasonStoltz
Copy link
Member

@JasonStoltz JasonStoltz commented Oct 8, 2020 •
edited
Loading

Summary

This PR adds an EuiEmptyState to the Credentials Page when no credentials are available.

https://user-images.githubusercontent.com/1427475/95224373-97689800-07c8-11eb-8982-f58f6b3001df.png

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@JasonStoltz JasonStoltz added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 8, 2020
@JasonStoltz JasonStoltz requested a review from a team October 8, 2020 17:33
scottybollinger
scottybollinger approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonStoltz JasonStoltz requested a review from cee-chen October 19, 2020 17:30
@JasonStoltz
Copy link
Member Author

@constancecchen Made some updates, how's it look to you?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 638.8KB 639.4KB +571.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JasonStoltz JasonStoltz merged commit 67ec846 into elastic:master Oct 19, 2020
@JasonStoltz JasonStoltz deleted the JasonStoltz/empty-state branch October 19, 2020 19:09
@JasonStoltz JasonStoltz mentioned this pull request Oct 19, 2020
Merged
JasonStoltz added a commit to JasonStoltz/kibana that referenced this pull request Oct 19, 2020
@JasonStoltz
[Enterprise Search] Added an EuiEmptyState to Credentials page #2 (el…
2a5221d 
…astic#80034)
JasonStoltz added a commit that referenced this pull request Oct 19, 2020
@JasonStoltz
[Enterprise Search] Added an EuiEmptyState to Credentials page #2 (#8…
40afb87 
…0034) (#81050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottybollinger scottybollinger scottybollinger approved these changes

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonStoltz @kibanamachine @cee-chen @scottybollinger