From fa0470d408b41cfa5d4686f502353e06a45f5ecc Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Thu, 16 Jul 2020 13:57:46 -0600 Subject: [PATCH 1/2] [QA][Code Coverage] Move the json def to easier location, such that devs can easily find it, change it and include those changes in their PR's. --- ...ipeline_painless.json => ingestion_pipeline_painless.json | 0 .../ingest_coverage/team_assignment/get_data.js | 5 ++--- 2 files changed, 2 insertions(+), 3 deletions(-) rename src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json => ingestion_pipeline_painless.json (100%) diff --git a/src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json b/ingestion_pipeline_painless.json similarity index 100% rename from src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json rename to ingestion_pipeline_painless.json diff --git a/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js b/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js index d9fbf5690d8a4..6438c8e714ca0 100644 --- a/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js +++ b/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js @@ -23,9 +23,8 @@ import { fromNullable } from '../either'; const ROOT = resolve(__dirname, '../../../../..'); const resolveFromRoot = resolve.bind(null, ROOT); -const path = ` -src/dev/code_coverage/ingest_coverage/team_assignment/ingestion_pipeline_painless.json`; -const resolved = resolveFromRoot(path.trimStart()); +const path = 'ingestion_pipeline_painless.json'; +const resolved = resolveFromRoot(path); const getContents = (scriptPath) => readFileSync(scriptPath, 'utf8'); export const fetch = () => fromNullable(resolved).map(getContents); From 11bf15594daa98b87f3fd706d6635a8295437ae5 Mon Sep 17 00:00:00 2001 From: Tre' Seymour Date: Fri, 17 Jul 2020 07:58:20 -0600 Subject: [PATCH 2/2] Change name per cr. --- ...pipeline_painless.json => code_coverage_team_assignment.json | 0 .../code_coverage/ingest_coverage/team_assignment/get_data.js | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) rename ingestion_pipeline_painless.json => code_coverage_team_assignment.json (100%) diff --git a/ingestion_pipeline_painless.json b/code_coverage_team_assignment.json similarity index 100% rename from ingestion_pipeline_painless.json rename to code_coverage_team_assignment.json diff --git a/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js b/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js index 6438c8e714ca0..b3cf2939b374b 100644 --- a/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js +++ b/src/dev/code_coverage/ingest_coverage/team_assignment/get_data.js @@ -23,7 +23,7 @@ import { fromNullable } from '../either'; const ROOT = resolve(__dirname, '../../../../..'); const resolveFromRoot = resolve.bind(null, ROOT); -const path = 'ingestion_pipeline_painless.json'; +const path = 'code_coverage_team_assignment.json'; const resolved = resolveFromRoot(path); const getContents = (scriptPath) => readFileSync(scriptPath, 'utf8');