[Logs UI] Anomalies page dataset filtering #71110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an anomalies API endpoint - Adds server side sorting / pagination to anomalies endpoint - Renders category examples in the anomalies table - Renames log entry rate examples to log entry examples
Make dataset fetching a common functionality Add anomaies datasets route Hook up datasets with client side hook and UI Hook up dataset filtering to anomalies API endpoint Hook up dataset filtering with log entry rate endpoint
Kerry350
force-pushed
the
71063-add-dataset-filtering-to-anomalies-page
branch
from
cb924a7 to
216cc9e
Compare
Kerry350
added
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
…entry_anomalies.ts Co-authored-by: Felix Stürmer <[email protected]>
afgomez
reviewed
Jul 9, 2020
There was a problem hiding this comment.
This is a first pass focused on functionality and on the most relevant commit until the blocking PR gets merged.
Functionality wise, it works! Code wise I can easily follow and understand what's going on. I have only a minor non-blocking comment about a small code duplication issue.
I'll wait until the blocking PR is merged to do a second pass and approve, but it's pretty much approved so far :)
...ins/infra/public/pages/logs/log_entry_rate/service_calls/get_log_entry_anomalies_datasets.ts
Outdated
Show resolved
Hide resolved
…alies-page-to-add-categories
…63-add-dataset-filtering-to-anomalies-page
…63-add-dataset-filtering-to-anomalies-page
|
@afgomez (For tomorrow): This is ready for another look, hopefully it can squeeze in before FF. The only notable changes from when you last looked at this are contained here: 0ec814e The anomalies results hook was refactored to use a reducer for managing state as different parts of the tree impact others, notably pagination needs to be reset when anything changes. The dataset filtering has been added to that state management. Everything else remains the same. |
…-filtering-to-anomalies-page
|
@elasticmachine merge upstream |
…b.com:Kerry350/kibana into 71063-add-dataset-filtering-to-anomalies-page
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
Kerry350
added a commit
to Kerry350/kibana
that referenced
this pull request
Jul 14, 2020
Adds dataset filtering to logs anomalies page
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 14, 2020
* master: (21 commits) [Maps] 7.9 design improvements (elastic#71563) [ML] Changing all calls to ML endpoints to use internal user (elastic#70487) [eventLog] prevent log writing when initialization fails (elastic#71339) [Observability] landing page always being displayed (elastic#71494) [IM] Address data stream copy feedback (elastic#71615) [Logs UI] Anomalies page dataset filtering (elastic#71110) [data.search.aggs] Remove `use_field_mapping` from top hits agg (elastic#71168) [ML] Anomaly swim lane embeddable navigation and filter actions (elastic#71082) Fixes typo in siem_cloudtrail job description (elastic#71569) Require granted API Keys to have a name (elastic#71623) Update getUsageForCollection (elastic#71609) Only fetch saved elements once (elastic#71310) [SecuritySolution][Resolver] Adding siem index and guarding process ancestry (elastic#71570) [APM] Additional data telemetry changes (elastic#71112) [Visualize] Fix export table for table export links (elastic#71249) [Search] Server side search API (elastic#70446) use inclusive language (elastic#71607) [Security Solution] Hide timeline footer when Resolver is open (elastic#71516) [Index template wizard] Remove shadow and use border for components panels (elastic#71606) [ML] Kibana API endpoint for histogram chart data (elastic#70976) ...
Kerry350
added a commit
that referenced
this pull request
Jul 14, 2020
Adds dataset filtering to logs anomalies page Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T REVIEW UNTIL #70982 IS MERGEDSummary
Adds dataset filtering to the anomalies page, closes #71063.
Testing