[Component templates] Address feedback #70912

alisonelizabeth · 2020-07-07T02:54:16Z

This PR addresses some of the feedback received on the component templates UI:

Added description under the "Component templates" tab
Added "Managed" badge with table filter
Added a call to action to create/edit an index template to the details panel when the template is not in use. Note: I made this an optional prop, as I don't think it makes sense to show this when the details panel is displayed in the "Components" step in the index templates wizard.
Addressed copy review feedback
Do not send empty mappings/settings/aliases objects (followed similar implementation as in [Composable template] Demo and PR review fixes #71065 (comment)).

Screenshots

…plates/feedback

elasticmachine · 2020-07-07T13:16:52Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth · 2020-07-09T10:34:31Z

@elasticmachine merge upstream

…plates/feedback

alisonelizabeth · 2020-07-13T11:33:59Z

@elasticmachine merge upstream

jloleysens

Great work @alisonelizabeth 👏🏻! I tested creating a component template and an index template (and editing both) and every was working as expected.

Left non-blocker comments.

jloleysens · 2020-07-13T12:00:39Z

...ion/components/component_templates/component_template_details/component_template_details.tsx

+
+          {componentTemplateDetails?._kbnMeta.isManaged ? (
+            <EuiFlexItem grow={false}>
+              {' '}


Is this whitespace intended to be included? Perhaps &npsb; would be better if so.

Yes, it is intentional. I'm going to leave as is for now, but will consider changing in a follow-up PR.

FYI the empty space that Alison used will allow a line break if the container forces the text to wrap, but a non-breaking space won’t allow this. In most situations I think we want the former behavior.

Thanks for pointing this out @cjcenizal!

FYI the empty space that Alison used will allow a line break if the container forces the text to wrap, but a non-breaking space won’t allow this. In most situations I think we want the former behavior.

@cjcenizal Not sure I understand correctly. Are we talking about 1 space difference (probably a few pixels) that would not wrap? Ex: hello world (there is a space before the "h"): where would this not wrap after "hello"?

I’m not sure if this answers your question but I was just pointing out that   !== ‘ ‘. The former won’t allow a line break on the space (“hello world” will overflow its container) while the latter will (“hello world” will break into two lines consisting of “hello” and “world”).

This is strange, I would need to try it out 😊 It would make sense if we were talking about hello world but here we are adding the before the 2 words.

jloleysens · 2020-07-13T12:45:34Z

...nent_templates/component_template_wizard/component_template_form/component_template_form.tsx

+  const cleanupComponentTemplateObject = (componentTemplate: ComponentTemplateDeserialized) => {
+    const outputTemplate = { ...componentTemplate };
+
+    if (outputTemplate.template.settings === undefined) {


Could there ever be a case where "settings", "mappings" or "aliases" is an empty object at this point? If so we should probably also delete that from the output template.

👍 It is already being stripped out here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/index_management/public/application/components/shared/components/wizard_steps/use_json_step.ts#L44

kibanamachine · 2020-07-13T13:19:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b61244e

Build metrics

✅ unchanged

History

💚 Build #60652 succeeded 48adbd2
💔 Build #60133 failed 13876c8
💚 Build #59628 succeeded e11fda6
💚 Build #59487 succeeded 97c4234
💚 Build #59460 succeeded 533cf63

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth added 2 commits July 6, 2020 22:06

address various feedback

6f15fb3

Merge branch 'master' of github.com:elastic/kibana into component_tem…

1d94828

…plates/feedback

alisonelizabeth added Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 7, 2020

update tests and add managed table filter

eeaa3f1

alisonelizabeth marked this pull request as ready for review July 7, 2020 13:16

alisonelizabeth requested a review from a team as a code owner July 7, 2020 13:16

alisonelizabeth requested a review from sebelga July 7, 2020 13:17

alisonelizabeth added 4 commits July 7, 2020 12:14

add learn more link

6d2d796

fix import

533cf63

update copy

97c4234

fix link navigation

e11fda6

elasticmachine and others added 4 commits July 9, 2020 04:34

Merge branch 'master' into component_templates/feedback

13876c8

Merge branch 'master' of github.com:elastic/kibana into component_tem…

2a37ccf

…plates/feedback

Merge branch 'master' of github.com:elastic/kibana into component_tem…

cc9d6e4

…plates/feedback

fix app navigation and clean up empty fields

48adbd2

Merge branch 'master' into component_templates/feedback

b61244e

jloleysens approved these changes Jul 13, 2020

View reviewed changes

alisonelizabeth merged commit 105afbc into elastic:master Jul 13, 2020

alisonelizabeth deleted the component_templates/feedback branch July 13, 2020 16:10

alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jul 13, 2020

[Component templates] Address feedback (elastic#70912)

7a6b436

alisonelizabeth mentioned this pull request Jul 13, 2020

[7.x] [Component templates] Address feedback (#70912) #71476

Merged

alisonelizabeth added a commit that referenced this pull request Jul 13, 2020

[Component templates] Address feedback (#70912) (#71476)

8c08c9a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Component templates] Address feedback #70912

[Component templates] Address feedback #70912

alisonelizabeth commented Jul 7, 2020 •

edited

Loading

elasticmachine commented Jul 7, 2020

alisonelizabeth commented Jul 9, 2020

alisonelizabeth commented Jul 13, 2020

jloleysens left a comment

jloleysens Jul 13, 2020

alisonelizabeth Jul 13, 2020

cjcenizal Jul 13, 2020

alisonelizabeth Jul 13, 2020

sebelga Jul 15, 2020 •

edited

Loading

cjcenizal Jul 15, 2020 •

edited

Loading

sebelga Jul 16, 2020

jloleysens Jul 13, 2020

alisonelizabeth Jul 13, 2020

kibanamachine commented Jul 13, 2020

[Component templates] Address feedback #70912

[Component templates] Address feedback #70912

Conversation

alisonelizabeth commented Jul 7, 2020 • edited Loading

Screenshots

elasticmachine commented Jul 7, 2020

alisonelizabeth commented Jul 9, 2020

alisonelizabeth commented Jul 13, 2020

jloleysens left a comment

Choose a reason for hiding this comment

jloleysens Jul 13, 2020

Choose a reason for hiding this comment

alisonelizabeth Jul 13, 2020

Choose a reason for hiding this comment

cjcenizal Jul 13, 2020

Choose a reason for hiding this comment

alisonelizabeth Jul 13, 2020

Choose a reason for hiding this comment

sebelga Jul 15, 2020 • edited Loading

Choose a reason for hiding this comment

cjcenizal Jul 15, 2020 • edited Loading

Choose a reason for hiding this comment

sebelga Jul 16, 2020

Choose a reason for hiding this comment

jloleysens Jul 13, 2020

Choose a reason for hiding this comment

alisonelizabeth Jul 13, 2020

Choose a reason for hiding this comment

kibanamachine commented Jul 13, 2020

💚 Build Succeeded

Build metrics

History

alisonelizabeth commented Jul 7, 2020 •

edited

Loading

sebelga Jul 15, 2020 •

edited

Loading

cjcenizal Jul 15, 2020 •

edited

Loading