Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Allow to configure Event Renderers settings #69693

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
b6768fe
WIP
patrykkopycinski Jun 21, 2020
d884e56
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jun 21, 2020
8dbdfbe
cleanup
patrykkopycinski Jun 23, 2020
3b4e91b
cleanup
patrykkopycinski Jun 23, 2020
786cb5e
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jun 23, 2020
4506311
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jun 23, 2020
131f52d
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jun 23, 2020
811703f
WIP
patrykkopycinski Jun 24, 2020
dcf9305
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jun 28, 2020
9b3b6d5
WIP
patrykkopycinski Jun 29, 2020
d2ab687
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jun 30, 2020
e4e929d
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 1, 2020
63e6f88
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 1, 2020
7f70abe
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 1, 2020
22c8d53
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 1, 2020
db36978
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 2, 2020
b88af37
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 2, 2020
51a10e5
modal
patrykkopycinski Jul 2, 2020
d1bfd34
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 2, 2020
a645f81
tableref
patrykkopycinski Jul 2, 2020
deab015
* Added `i18n` descriptions and links to documentation
andrew-goldstein Jul 3, 2020
3703af3
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 6, 2020
f7aaa45
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 6, 2020
2d442b7
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 6, 2020
1e45626
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 6, 2020
ddaba85
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 7, 2020
cc23fe4
cleanup all
patrykkopycinski Jul 7, 2020
905342d
cleanup
patrykkopycinski Jul 7, 2020
9770d17
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 7, 2020
589f94e
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 7, 2020
0497cff
cleanup
patrykkopycinski Jul 7, 2020
34ad058
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 7, 2020
ded219d
cleanup
patrykkopycinski Jul 7, 2020
bff2537
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 8, 2020
59ca9da
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 8, 2020
e5c7f1a
PR comments
patrykkopycinski Jul 8, 2020
ef3c87d
Merge branch 'master' into feat/row-renderers-settings
elasticmachine Jul 8, 2020
de54992
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 8, 2020
c2e7f50
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 9, 2020
a065423
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 9, 2020
60152d7
PR comments
patrykkopycinski Jul 9, 2020
ad26ee4
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 9, 2020
fd18049
Fix styling
patrykkopycinski Jul 9, 2020
f0ada33
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 9, 2020
728c43c
fix styling
patrykkopycinski Jul 9, 2020
e2b9e4d
Merge branch 'master' into feat/row-renderers-settings
elasticmachine Jul 9, 2020
255681f
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 9, 2020
2d773ff
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 9, 2020
ee8a2c3
Fix merge
patrykkopycinski Jul 9, 2020
cbd7820
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 10, 2020
c65bc88
Fix styling
patrykkopycinski Jul 10, 2020
6b1247f
Merge branch 'master' of github.com:elastic/kibana into feat/row-rend…
patrykkopycinski Jul 10, 2020
7305969
fix flyout
patrykkopycinski Jul 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions x-pack/plugins/security_solution/common/types/timeline/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
* you may not use this file except in compliance with the Elastic License.
*/

/* eslint-disable @typescript-eslint/no-empty-interface */
/* eslint-disable @typescript-eslint/camelcase, @typescript-eslint/no-empty-interface */

import * as runtimeTypes from 'io-ts';
import { SavedObjectsClient } from 'kibana/server';

import { unionWithNullType } from '../../utility_types';
import { stringEnum, unionWithNullType } from '../../utility_types';
import { NoteSavedObject, NoteSavedObjectToReturnRuntimeType } from './note';
import { PinnedEventToReturnSavedObjectRuntimeType, PinnedEventSavedObject } from './pinned_event';

Expand Down Expand Up @@ -164,6 +164,24 @@ export type TimelineStatusLiteralWithNull = runtimeTypes.TypeOf<
typeof TimelineStatusLiteralWithNullRt
>;

export enum RowRendererId {
auditd = 'auditd',
auditd_file = 'auditd_file',
netflow = 'netflow',
plain = 'plain',
suricata = 'suricata',
system = 'system',
system_dns = 'system_dns',
system_endgame_process = 'system_endgame_process',
system_file = 'system_file',
system_fim = 'system_fim',
system_security_event = 'system_security_event',
system_socket = 'system_socket',
zeek = 'zeek',
}

export const RowRendererIdRuntimeType = stringEnum(RowRendererId, 'RowRendererId');

/**
* Timeline template type
*/
Expand Down Expand Up @@ -211,6 +229,7 @@ export const SavedTimelineRuntimeType = runtimeTypes.partial({
dataProviders: unionWithNullType(runtimeTypes.array(SavedDataProviderRuntimeType)),
description: unionWithNullType(runtimeTypes.string),
eventType: unionWithNullType(runtimeTypes.string),
excludedRowRendererIds: unionWithNullType(runtimeTypes.array(RowRendererIdRuntimeType)),
favorite: unionWithNullType(runtimeTypes.array(SavedFavoriteRuntimeType)),
filters: unionWithNullType(runtimeTypes.array(SavedFilterRuntimeType)),
kqlMode: unionWithNullType(runtimeTypes.string),
Expand Down
11 changes: 11 additions & 0 deletions x-pack/plugins/security_solution/common/utility_types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,14 @@ export interface DescriptionList {

export const unionWithNullType = <T extends runtimeTypes.Mixed>(type: T) =>
runtimeTypes.union([type, runtimeTypes.null]);

export const stringEnum = <T>(enumObj: T, enumName = 'enum') =>
new runtimeTypes.Type<T[keyof T], string>(
enumName,
(u): u is T[keyof T] => Object.values(enumObj).includes(u),
(u, c) =>
Object.values(enumObj).includes(u)
? runtimeTypes.success(u as T[keyof T])
: runtimeTypes.failure(u, c),
(a) => (a as unknown) as string
);
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
export const CLOSE_MODAL = '[data-test-subj="modal-inspect-close"]';

export const EVENTS_VIEWER_FIELDS_BUTTON =
'[data-test-subj="events-viewer-panel"] [data-test-subj="show-field-browser-gear"]';
'[data-test-subj="events-viewer-panel"] [data-test-subj="show-field-browser"]';

export const EVENTS_VIEWER_PANEL = '[data-test-subj="events-viewer-panel"]';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import { RowRendererId } from '../../../../common/types/timeline';
import { defaultColumnHeaderType } from '../../../timelines/components/timeline/body/column_headers/default_headers';
import {
DEFAULT_COLUMN_MIN_WIDTH,
Expand Down Expand Up @@ -69,5 +70,5 @@ export const alertsHeaders: ColumnHeaderOptions[] = [
export const alertsDefaultModel: SubsetTimelineModel = {
...timelineDefaults,
columns: alertsHeaders,
showRowRenderers: false,
excludedRowRendererIds: Object.values(RowRendererId),
};
Loading