From 065d2c323ecfb46be81e0fdbd0219d4cf9ab7bd9 Mon Sep 17 00:00:00 2001
From: Zacqary Xeper <zacqary.xeper@elastic.co>
Date: Tue, 7 Apr 2020 12:41:25 -0500
Subject: [PATCH] Invalidate non-count alerts which have no metrics

---
 .../public/components/alerting/metrics/validation.tsx  | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/x-pack/plugins/infra/public/components/alerting/metrics/validation.tsx b/x-pack/plugins/infra/public/components/alerting/metrics/validation.tsx
index 0f5b07f8c0e13..2cd59b3381bdc 100644
--- a/x-pack/plugins/infra/public/components/alerting/metrics/validation.tsx
+++ b/x-pack/plugins/infra/public/components/alerting/metrics/validation.tsx
@@ -24,6 +24,7 @@ export function validateMetricThreshold({
       timeWindowSize: string[];
       threshold0: string[];
       threshold1: string[];
+      metric: string[];
     };
   } = {};
   validationResult.errors = errors;
@@ -42,6 +43,7 @@ export function validateMetricThreshold({
       timeWindowSize: [],
       threshold0: [],
       threshold1: [],
+      metric: [],
     };
     if (!c.aggType) {
       errors[id].aggField.push(
@@ -74,6 +76,14 @@ export function validateMetricThreshold({
         })
       );
     }
+
+    if (!c.metric && c.aggType !== 'count') {
+      errors[id].metric.push(
+        i18n.translate('xpack.infra.metrics.alertFlyout.error.metricRequired', {
+          defaultMessage: 'Metric is required.',
+        })
+      );
+    }
   });
 
   return validationResult;