-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix find by apiKeyId escaping #61816
Merged
nchaulet
merged 7 commits into
elastic:master
from
nchaulet:feature-ingest-fix-api-key-id-escaping
Apr 3, 2020
Merged
[Fleet] Fix find by apiKeyId escaping #61816
nchaulet
merged 7 commits into
elastic:master
from
nchaulet:feature-ingest-fix-api-key-id-escaping
Apr 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
Feature:EPM
Fleet team's Elastic Package Manager (aka Integrations) project
Feature:Fleet
Fleet team's agent central management project
labels
Mar 30, 2020
Pinging @elastic/ingest-management (Feature:EPM) |
nchaulet
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.8.0
v8.0.0
labels
Mar 30, 2020
nnamdifrankie
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes.
@elasticmachine merge upstream |
…chaulet/kibana into feature-ingest-fix-api-key-id-escaping
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
neptunian
approved these changes
Apr 3, 2020
nchaulet
added a commit
that referenced
this pull request
Apr 3, 2020
This was referenced Apr 6, 2020
jen-huang
added
Team:Fleet
Team label for Observability Data Collection Fleet team
and removed
Feature:EPM
Fleet team's Elastic Package Manager (aka Integrations) project
labels
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Fleet
Fleet team's agent central management project
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #61796
Related to #60471 #60865
We were not returning the correct saved object when the API key id was starting with
-
, the search is now escaped.and this tests is passing, was failing before