ServiceNow action improvements #60052

cnasikas · 2020-03-12T18:36:16Z

Summary

This PR improves ServiceNow action. Specifically implements the functionality of the following action types: nothing, overwrite, and append.

Action Type	Description
nothing	The field will be not updated on ServiceNow
overwrite	The field will be updated and overwritten on ServiceNow
append	The field will be updated but the new value will be appended at the end of the previous value separate the two values by `\r\n`

API (new changes)

Create an incident:

Crate an incident to ServiceNow. When the incidentId attribute is not in params the executor will create the incident.

Endpoint: api/action/<action_id>/_execute
Method: POST

Payload:

{
    "params": {
    	"caseId": "d4387ac5-0899-4dc2-bbfa-0dd605c934aa",
        "title": "test new features",
        "description": "Test description creation new changes",
        "createdAt": "2020-03-13T08:34:53.450Z",
        "createdBy": { "fullName": "Elastic User", "username": "elastic" },
        "comments": [
            {
                "commentId": "b5b4c4d0-574e-11ea-9e2e-21b90f8a9631",
                "version": "WzU3LDFd",
                "comment": "comment",
                "createdAt": "2020-03-13T08:34:53.450Z",
                "createdBy": { "fullName": "Elastic User", "username": "elastic" }
            },
             {
                "commentId": "b5b4c4d0-574e-11ea-9e2e-21b90f8a9631",
                "version": "WzU3LDFd",
                "comment": "second comment",
                "createdAt": "2020-03-13T08:34:53.450Z",
                "createdBy": { "fullName": "Elastic User", "username": "elastic" }
            }
        ]
    }
}

Response

{
    "status": "ok",
    "actionId": "f631be57-0a59-4e28-8833-16fc3b309374",
    "data": {
        "incidentId": "7d7aad9c072fc0100e48fbbf7c1ed0c2",
        "number": "INC0010044",
        "pushedDate": "2020-03-10T13:02:59.000Z",
        "comments": [
            {
                "commentId": "b5b4c4d0-574e-11ea-9e2e-21b90f8a9631",
                "pushedDate": "2020-03-10T13:03:00.000Z"
            }
        ]
    }
}

Update an incident:

Update an incident to ServiceNow. When the incidentId attribute is in params the executor will update the incident.

Endpoint: api/action/<action_id>/_execute
Method: POST

Payload:

{
    "params": {
    	"params": {
        "caseId": "d4387ac5-0899-4dc2-bbfa-0dd605c934aa",
        "incidentId": "5addbc9e2fe70010bf1cfcecf699b692",
        "title": "Update title",
        "description": "Update description",
        "createdAt": "2020-03-13T08:34:53.450Z",
        "createdBy": { "fullName": "Elastic User", "username": "elastic" },
        "updatedBy": { "fullName": "Elastic User", "username": "elastic" },
        "updatedAt": "2020-03-13T08:35:12.279Z",
        "comments": [
            {
                "commentId": "b5b4c4d0-574e-11ea-9e2e-21b90f8a9631",
                "version": "WzU3LDFd",
                "comment": "a comment",
                "createdAt": "2020-03-13T08:34:53.450Z",
                "createdBy": { "fullName": "Elastic User 2" , "username": "elastic2" }
            },
            {
                "commentId": "b5b4c4d0-574e-11ea-9e2e-21b90f8a9631",
                "version": "WzU3LDFd",
                "comment": "another comment",
                "createdAt": "2020-03-13T08:34:53.450Z",
                "createdBy": { "fullName": "Elastic User", "username": "elastic"  },
                "updatedBy": { "fullName": "Elastic User", "username": "elastic" },
                "updatedAt": "2020-03-13T08:35:12.279Z"
            }
        ]
    }
}

Response

{
    "status": "ok",
    "actionId": "f631be57-0a59-4e28-8833-16fc3b309374",
    "data": {
        "incidentId": "7d7aad9c072fc0100e48fbbf7c1ed0c2",
        "number": "INC0010044",
        "pushedDate": "2020-03-10T13:02:59.000Z",
        "comments": [
            {
                "commentId": "b5b4c4d0-574e-11ea-9e2e-21b90f8a9631",
                "pushedDate": "2020-03-10T13:03:00.000Z"
            }
        ]
    }
}

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-03-12T18:36:18Z

Pinging @elastic/siem (Team:SIEM)

elasticmachine · 2020-03-13T12:37:13Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

x-pack/plugins/actions/server/builtin_action_types/servicenow/action_handlers.test.ts

x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.ts

x-pack/plugins/actions/server/builtin_action_types/servicenow/index.test.ts

x-pack/plugins/actions/server/builtin_action_types/servicenow/schema.ts

x-pack/plugins/actions/server/builtin_action_types/servicenow/transformers.ts

cnasikas · 2020-03-17T16:10:22Z

@elasticmachine merge upstream

pmuellr

From an alerting/actions point of view, this code LGTM - made a comment about a possible restructuring of config-schema definitions, not a big deal.

x-pack/plugins/actions/server/builtin_action_types/servicenow/schema.ts

cnasikas · 2020-03-17T19:27:37Z

@elasticmachine merge upstream

YulNaumenko

LGTM

cnasikas · 2020-03-17T20:33:18Z

@elasticmachine merge upstream

x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.ts

kibanamachine · 2020-03-18T12:12:59Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 2651848
Flaky suites:
- kibana-accessibility

Test Failures

Kibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/management·ts.Management Create Index pattern wizard

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/60470

[00:00:00]       │
[00:05:38]         └-: Management
[00:05:38]           └-> "before all" hook
[00:05:38]           └-> "before all" hook
[00:05:38]             │ info [discover] Loading "mappings.json"
[00:05:38]             │ info [discover] Loading "data.json.gz"
[00:05:38]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_2/Wukni08qSHS4JTYENp6oxQ] deleting index
[00:05:38]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_1/zw-0DOy_QLiyoQAvf7DT-g] deleting index
[00:05:38]             │ info [discover] Deleted existing index [".kibana_2",".kibana_1"]
[00:05:38]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:05:38]             │ info [discover] Created index ".kibana"
[00:05:38]             │ debg [discover] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:05:38]             │ info [discover] Indexed 2 docs into ".kibana"
[00:05:38]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana/QfcFatbSSAe7TrdqqqXl5Q] update_mapping [_doc]
[00:05:38]             │ debg Migrating saved objects
[00:05:39]             │ proc [kibana]   log   [10:59:32.459] [info][savedobjects-service] Creating index .kibana_2.
[00:05:39]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:05:39]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] updating number_of_replicas to [0] for indices [.kibana_2]
[00:05:39]             │ proc [kibana]   log   [10:59:32.524] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:05:39]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:05:39]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] updating number_of_replicas to [0] for indices [.kibana_1]
[00:05:39]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] 1934 finished with response BulkByScrollResponse[took=26.2ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:05:39]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana/QfcFatbSSAe7TrdqqqXl5Q] deleting index
[00:05:39]             │ proc [kibana]   log   [10:59:32.875] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:05:39]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_2/5ebi2POtTU-XXgSOVAiV_g] update_mapping [_doc]
[00:05:39]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_2/5ebi2POtTU-XXgSOVAiV_g] update_mapping [_doc]
[00:05:39]             │ proc [kibana]   log   [10:59:32.956] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:05:39]             │ proc [kibana]   log   [10:59:32.993] [info][savedobjects-service] Finished in 536ms.
[00:05:39]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:05:40]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_2/5ebi2POtTU-XXgSOVAiV_g] update_mapping [_doc]
[00:05:41]             │ info [logstash_functional] Loading "mappings.json"
[00:05:41]             │ info [logstash_functional] Loading "data.json.gz"
[00:05:41]             │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:05:41]             │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:05:41]             │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:05:42]             │ debg applying update to kibana config: {"defaultIndex":"logstash-*"}
[00:05:42]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1584527531647227905] [.kibana_2/5ebi2POtTU-XXgSOVAiV_g] update_mapping [_doc]
[00:05:43]             │ debg navigating to settings url: http://localhost:61131/app/kibana#/management
[00:05:43]             │ debg Navigate to: http://localhost:61131/app/kibana#/management
[00:05:43]             │ debg ... sleep(700) start
[00:05:43]             │ debg browser[INFO] http://localhost:61131/app/kibana?_t=1584529176537#/management 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:05:43]             │
[00:05:43]             │ debg browser[INFO] http://localhost:61131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:05:43]             │ debg ... sleep(700) end
[00:05:43]             │ debg returned from get, calling refresh
[00:05:44]             │ debg browser[INFO] http://localhost:61131/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-18T10:59:37Z
[00:05:44]             │        Adding connection to http://localhost:61131/elasticsearch
[00:05:44]             │
[00:05:44]             │      "
[00:05:44]             │ERROR browser[SEVERE] http://localhost:61131/bundles/commons.bundle.js 0:1388557 TypeError: Failed to fetch
[00:05:44]             │          at Fetch._callee3$ (http://localhost:61131/bundles/commons.bundle.js:1:1415714)
[00:05:44]             │          at l (http://localhost:61131/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1041899)
[00:05:44]             │          at Generator._invoke (http://localhost:61131/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1041652)
[00:05:44]             │          at Generator.forEach.e.<computed> [as throw] (http://localhost:61131/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1042256)
[00:05:44]             │          at asyncGeneratorStep (http://localhost:61131/bundles/commons.bundle.js:1:1410211)
[00:05:44]             │          at _throw (http://localhost:61131/bundles/commons.bundle.js:1:1410608)
[00:05:44]             │ debg browser[INFO] http://localhost:61131/app/kibana?_t=1584529176537#/management 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:05:44]             │
[00:05:44]             │ debg browser[INFO] http://localhost:61131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:05:44]             │ debg currentUrl = http://localhost:61131/app/kibana#/management
[00:05:44]             │          appUrl = http://localhost:61131/app/kibana#/management
[00:05:44]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:05:46]             │ debg TestSubjects.find(kibanaChrome)
[00:05:46]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:05:46]             │ debg browser[INFO] http://localhost:61131/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-18T10:59:39Z
[00:05:46]             │        Adding connection to http://localhost:61131/elasticsearch
[00:05:46]             │
[00:05:46]             │      "
[00:05:46]             │ debg ... sleep(501) start
[00:05:46]             │ debg ... sleep(501) end
[00:05:46]             │ debg in navigateTo url = http://localhost:61131/app/kibana#/management?_g=()
[00:05:46]             │ debg TestSubjects.exists(statusPageContainer)
[00:05:46]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:05:49]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:05:50]           └-> main view
[00:05:50]             └-> "before each" hook: global before each
[00:05:50]             └- ✓ pass  (455ms) "Management main view"
[00:05:50]           └-> index pattern page
[00:05:50]             └-> "before each" hook: global before each
[00:05:50]             │ debg clickKibanaIndexPatterns link
[00:05:50]             │ debg TestSubjects.click(index_patterns)
[00:05:50]             │ debg Find.clickByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:05:50]             │ debg Find.findByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:05:50]             │ debg isGlobalLoadingIndicatorVisible
[00:05:50]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:05:50]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:05:50]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:05:52]             │ debg --- retry.tryForTime failed again with the same message...
[00:05:53]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:05:53]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:05:53]             │ debg Waiting up to 20000ms for index pattern info flyout...
[00:05:53]             │ debg TestSubjects.exists(CreateIndexPatternPrompt)
[00:05:53]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="CreateIndexPatternPrompt"]') with timeout=2500
[00:05:55]             │ debg --- retry.tryForTime error: [data-test-subj="CreateIndexPatternPrompt"] is not displayed
[00:05:56]             └- ✓ pass  (6.1s) "Management index pattern page"
[00:05:56]           └-> Single indexpattern view
[00:05:56]             └-> "before each" hook: global before each
[00:05:56]             │ debg Find.byXPath('//a[descendant::*[text()='logstash-*']]') with timeout=10000
[00:05:57]             └- ✓ pass  (487ms) "Management Single indexpattern view"
[00:05:57]           └-> Create Index pattern wizard
[00:05:57]             └-> "before each" hook: global before each
[00:05:57]             │ debg clickKibanaIndexPatterns link
[00:05:57]             │ debg TestSubjects.click(index_patterns)
[00:05:57]             │ debg Find.clickByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:05:57]             │ debg Find.findByCssSelector('[data-test-subj="index_patterns"]') with timeout=10000
[00:05:57]             │ debg isGlobalLoadingIndicatorVisible
[00:05:57]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:05:57]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:05:58]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:05:59]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:05:59]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:05:59]             │ debg Waiting up to 20000ms for index pattern info flyout...
[00:05:59]             │ debg TestSubjects.exists(CreateIndexPatternPrompt)
[00:05:59]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="CreateIndexPatternPrompt"]') with timeout=2500
[00:06:02]             │ debg --- retry.tryForTime error: [data-test-subj="CreateIndexPatternPrompt"] is not displayed
[00:06:02]             │ debg TestSubjects.find(createIndexPatternButton)
[00:06:02]             │ debg Find.findByCssSelector('[data-test-subj="createIndexPatternButton"]') with timeout=10000
[00:06:12]             │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/Management Create Index pattern wizard.png"
[00:06:12]             │ info Current URL is: http://localhost:61131/app/kibana#/management/kibana/index_patterns/logstash-*?_g=()&_a=(tab:indexedFields)
[00:06:12]             │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/Management Create Index pattern wizard.html
[00:06:12]             └- ✖ fail: "Management Create Index pattern wizard"
[00:06:12]             │

Stack Trace

{ TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="createIndexPatternButton"])
Wait timed out after 10005ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError', remoteStacktrace: '' }

History

💔 Build #34102 failed e08ab39
💔 Build #33973 failed 2bc1fa5
💔 Build #33905 failed 5e295fcf64e44513cc46bbc35ba12965ee77cb4d
💚 Build #33859 succeeded f19c98d8f660dd03ee89120850e4f4becddde624
💚 Build #33514 succeeded a6e2061ce617405b33a602014f1ec8c7df6602b5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic

LGTM 🚀

* Apply action types to fields * Add information to each field * Do not create or update comments when actionType is set to nothing * Improve helpers tests * Improve tests * Refactor: Use transformers and pipes * Better types * Refactor tests to new changes * Better error messages * Improve field formatting and display * Improve integration tests * Make username mandatory field * Translate transformers * Refactor schema * Translate appendInformationToField helper * Improve intergration tests Co-authored-by: Elastic Machine <[email protected]>

* Apply action types to fields * Add information to each field * Do not create or update comments when actionType is set to nothing * Improve helpers tests * Improve tests * Refactor: Use transformers and pipes * Better types * Refactor tests to new changes * Better error messages * Improve field formatting and display * Improve integration tests * Make username mandatory field * Translate transformers * Refactor schema * Translate appendInformationToField helper * Improve intergration tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

* master: (35 commits) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) [Maps] Mark instance state as readonly (elastic#60557) Move ui/indices into es_ui_shared plugin. (elastic#60186) ServiceNow action improvements (elastic#60052) ...

* master: (64 commits) [Alerting] Adds navigation by consumer and alert type to alerting (elastic#58997) Introduce search interceptor (elastic#60523) [ML] Add functional tests for file data visualizer (elastic#60413) [APM] Optimize service map query (elastic#60412) [SIEM][Detection Engine] Adds lists feature flag and list values to the REST interfaces Enhancement/update esdocs datasource (elastic#59512) [junit] only include stdout in report for failures (elastic#60530) Update dependency nock to v12 (elastic#60422) upgrade execa to get stdout/stderr in error messages (elastic#60537) skip flaky suite (elastic#60471) [Ingest] Agent Config Details - Data sources list ui (elastic#60429) [SIEM] Create ML Rules (elastic#58053) skip flaky suite (elastic#60559) fix agent type (elastic#60554) Fixed default message for index threshold includes both threshold values (elastic#60545) [Ingest] Add support for `yaml` field types (elastic#60440) Solved the issue for a GROUP BY expression validation (elastic#60558) [Maps] Mark instance state as readonly (elastic#60557) Move ui/indices into es_ui_shared plugin. (elastic#60186) ServiceNow action improvements (elastic#60052) ...

cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 12, 2020

cnasikas added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Mar 13, 2020

cnasikas marked this pull request as ready for review March 13, 2020 19:32

cnasikas requested a review from a team as a code owner March 13, 2020 19:32

cnasikas requested review from XavierM and stephmilovic March 13, 2020 19:34

cnasikas force-pushed the servinow_improvements branch 6 times, most recently from af07139 to b8f5a72 Compare March 16, 2020 17:10

cnasikas requested review from mikecote and YulNaumenko March 16, 2020 19:53

cnasikas mentioned this pull request Mar 17, 2020

[SIEM] [Docs] Cases API elastic/stack-docs#761

Merged

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/action_handlers.test.ts Show resolved Hide resolved

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.ts Show resolved Hide resolved

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/index.test.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/index.test.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/schema.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/transformers.ts Outdated Show resolved Hide resolved

cnasikas requested a review from stephmilovic March 17, 2020 17:12

cnasikas added 2 commits March 17, 2020 19:18

Apply action types to fields

3fc70e9

Add information to each field

915306d

cnasikas removed request for a team March 17, 2020 17:24

pmuellr approved these changes Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/schema.ts Outdated Show resolved Hide resolved

cnasikas added 2 commits March 17, 2020 20:35

Translate transformers

b1ea620

Refactor schema

2a831fc

cnasikas force-pushed the servinow_improvements branch from b9e7742 to 2a831fc Compare March 17, 2020 18:37

Merge branch 'master' into servinow_improvements

91d2075

YulNaumenko approved these changes Mar 17, 2020

View reviewed changes

Merge branch 'master' into servinow_improvements

2bc1fa5

stephmilovic reviewed Mar 17, 2020

View reviewed changes

x-pack/plugins/actions/server/builtin_action_types/servicenow/helpers.ts Outdated Show resolved Hide resolved

cnasikas added 2 commits March 18, 2020 11:04

Translate appendInformationToField helper

e08ab39

Improve intergration tests

2651848

mikecote removed their request for review March 18, 2020 12:21

stephmilovic approved these changes Mar 18, 2020

View reviewed changes

cnasikas merged commit 24534e8 into elastic:master Mar 18, 2020

cnasikas mentioned this pull request Mar 18, 2020

[7.x] ServiceNow action improvements (#60052) #60552

Merged

mikecote added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ServiceNow action improvements #60052

ServiceNow action improvements #60052

cnasikas commented Mar 12, 2020 •

edited

Loading

elasticmachine commented Mar 12, 2020

elasticmachine commented Mar 13, 2020

cnasikas commented Mar 17, 2020

pmuellr left a comment

cnasikas commented Mar 17, 2020

YulNaumenko left a comment

cnasikas commented Mar 17, 2020

kibanamachine commented Mar 18, 2020

Standard Out

Stack Trace

stephmilovic left a comment

ServiceNow action improvements #60052

ServiceNow action improvements #60052

Conversation

cnasikas commented Mar 12, 2020 • edited Loading

Summary

API (new changes)

Create an incident:

Update an incident:

Checklist

For maintainers

elasticmachine commented Mar 12, 2020

elasticmachine commented Mar 13, 2020

cnasikas commented Mar 17, 2020

pmuellr left a comment

Choose a reason for hiding this comment

cnasikas commented Mar 17, 2020

YulNaumenko left a comment

Choose a reason for hiding this comment

cnasikas commented Mar 17, 2020

kibanamachine commented Mar 18, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

stephmilovic left a comment

Choose a reason for hiding this comment

cnasikas commented Mar 12, 2020 •

edited

Loading