Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service map popover transaction duration #58422

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 25, 2020

It's already microseconds, so not converting it fixes it.

Checked services to see if all metrics match now and they do!

Fixes #55679

@smith smith requested a review from a team as a code owner February 25, 2020 00:18
@ogupte ogupte added the v7.7.0 label Feb 25, 2020
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@smith smith added release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support labels Feb 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

It's already microseconds, so not converting it fixes it.

Checked services to see if all metrics match now and they do!

Fixes elastic#55679
@smith smith force-pushed the nls/fix-trans-dur branch from 7beaae7 to 815164a Compare February 25, 2020 03:34
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #28667 failed 7beaae703f7777c1f62cc746721357c2e29c5fb3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit afb5d8f into elastic:master Feb 25, 2020
@smith smith deleted the nls/fix-trans-dur branch February 25, 2020 13:43
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 25, 2020
…re/files-and-filetree

* 'master' of github.com:elastic/kibana: (174 commits)
  [SIEM] Fix unnecessary re-renders on the Overview page (elastic#56587)
  Don't mutate error message (elastic#58452)
  Fix service map popover transaction duration (elastic#58422)
  [ML] Adding filebeat config to file dataviz (elastic#58152)
  [Uptime] Improve refresh handling when generating test data (elastic#58285)
  [Logs / Metrics UI] Remove path prefix from ViewSourceConfigur… (elastic#58238)
  [ML] Functional tests - adjust classification model memory (elastic#58445)
  [ML] Use event.timezone instead of beat.timezone in file upload (elastic#58447)
  [Logs UI] Unskip and stabilitize log column configuration tests (elastic#58392)
  [Telemetry] Separate the license retrieval from the stats in the usage collectors (elastic#57332)
  hide welcome screen for cloud (elastic#58371)
  Move src/legacy/ui/public/notify/app_redirect to kibana_legacy (elastic#58127)
  [ML] Functional tests - stabilize typing during df analytics creation (elastic#58227)
  fix short url in spaces (elastic#58313)
  [SIEM] Upgrades cypress to version 4.0.2 (elastic#58400)
  [Index management] Move to new platform "plugins" folder (elastic#58109)
  [kbn/optimizer] disable parallelization in terser plugin (elastic#58396)
  [Uptime] Delete useless try...catch blocks (elastic#58263)
  [Uptime] Use scripted metric for snapshot calculation (elastic#58247) (elastic#58389)
  [APM] Stabilize agent configuration API (elastic#57767)
  ...

# Conflicts:
#	src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
smith added a commit to smith/kibana that referenced this pull request Feb 26, 2020
It's already microseconds, so not converting it fixes it.

Checked services to see if all metrics match now and they do!

Fixes elastic#55679
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 26, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 26, 2020
smith added a commit that referenced this pull request Feb 26, 2020
It's already microseconds, so not converting it fixes it.

Checked services to see if all metrics match now and they do!

Fixes #55679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Average transaction duration in Service Map overview is wrong
4 participants