-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable url tracking for dashboard #55818
Merged
flash1293
merged 37 commits into
elastic:master
from
flash1293:disable-url-tracking-for-dashboard
Feb 5, 2020
Merged
Changes from 36 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3ac4119
Remove GlobalState from Dashboard App
Dosant b343638
move filters syncing utility to data plugin
Dosant 79850bf
improve
Dosant 7189cf6
test
Dosant 4ad51c3
fix bug
Dosant 74acc33
add setGlobalFilters & setGlobalFilters methods
Dosant f5affd5
Merge branch 'dev/filter-manager-set-app-set-global-filters' of githu…
Dosant 4844420
introduce flag for disabling sub url tracking
flash1293 9c8678d
Merge remote-tracking branch 'upstream/master' into exclude-sub-url-t…
flash1293 e41b273
improve
Dosant 8d0d0df
fix lint
Dosant df90a14
Merge branch 'exclude-sub-url-tracking' into disable-url-tracking-for…
flash1293 4fb7b78
start implementing local handling for sub url tracking
flash1293 5200092
Merge remote-tracking branch 'upstream/master' into exclude-sub-url-t…
flash1293 374d8b2
re-generate documentation and extend ui_app
flash1293 0b03d6f
Merge remote-tracking branch 'upstream/master' into exclude-sub-url-t…
flash1293 0a744f4
fix ui_nav_link test
flash1293 4b2de2a
Merge branch 'exclude-sub-url-tracking' into disable-url-tracking-for…
flash1293 e72edd0
move everything into one helper
flash1293 d671a36
continue fleshing out functionalirty
flash1293 9777074
Merge branch 'master' into exclude-sub-url-tracking
elasticmachine 2a4e7ca
Merge remote-tracking branch 'upstream/master' into disable-url-track…
flash1293 8232a49
Merge remote-tracking branch 'upstream/master' into exclude-sub-url-t…
flash1293 1d77849
Merge branch 'exclude-sub-url-tracking' of github.com:flash1293/kiban…
flash1293 3e7c1a5
Merge branch 'exclude-sub-url-tracking' into disable-url-tracking-for…
flash1293 9958a9a
make it work in dashboards
flash1293 e1d5932
Merge remote-tracking branch 'upstream/master' into disable-url-track…
flash1293 44234a8
revert standard url tracker changes
flash1293 4921fda
Merge remote-tracking branch 'upstream/master' into disable-url-track…
flash1293 b28cbbd
fix types and add tests
flash1293 2d29fbb
fix type
flash1293 f63f589
dont parse URL to avoid decoding url params
flash1293 6d26b89
Merge remote-tracking branch 'upstream/master' into disable-url-track…
flash1293 25087e9
fix hashed urls
flash1293 508f9da
Merge remote-tracking branch 'upstream/master' into disable-url-track…
flash1293 9e8ef0b
PR review comments
flash1293 9bf5a59
Merge remote-tracking branch 'upstream/master' into disable-url-track…
flash1293 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we will have to add this to
data
plugin as part of the api. Because with current setup, if to apply this for multiple apps: each app will create a state container, which will all the time independently orchestratedata.query
changes.So we should add 1 state container on a data plugin, which apps could reuse and receive the updates.
cc @lizozom, I think you've mentioned something like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's even worse than that - the
syncState
helper is also creating its own state container, so even the dashboard plugin alone will have two of them running while the app is mounted. +1 for exposing it once via setup contract and using it everywhere from there.