Explicitly test custom appRoutes #55405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliperelman
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
eliperelman
force-pushed
the
feature/explicit-approute
branch
from
4682ad2 to
8cd78e5
Compare
eliperelman
force-pushed
the
feature/explicit-approute
branch
from
8cd78e5 to
4fdf425
Compare
eliperelman
added
the
release_note:plugin_api_changes
|
cc: @joshdover @restrry @jinmu03 |
pgayvallet
reviewed
Jan 22, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Jan 23, 2020
eliperelman
added a commit
to eliperelman/kibana
that referenced
this pull request
Jan 23, 2020
* Explicitly test custom appRoutes * Extract common navigation function
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Feb 7, 2020
* Explicitly test custom appRoutes * Extract common navigation function Fixing flaky CI tests for custom appRoutes
mshustov
added a commit
that referenced
this pull request
Feb 8, 2020
* Explicitly test custom appRoutes (#55405) * Explicitly test custom appRoutes * Extract common navigation function Fixing flaky CI tests for custom appRoutes * test only flaky tests. DO NOT MERGE IN 7.x
mshustov
added a commit
that referenced
this pull request
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dev Docs
Tests for custom
appRoutes are now more clear and explicitly separate from those that test other rendering service interactions.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately