From 2be8e6b1de254d89c520dab275c19993b5ccee1e Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 19 Dec 2019 13:50:11 -0600 Subject: [PATCH 1/5] eui to 17.3.0 --- package.json | 2 +- .../plugins/kbn_tp_run_pipeline/package.json | 2 +- .../plugins/kbn_tp_custom_visualizations/package.json | 2 +- .../plugins/kbn_tp_embeddable_explorer/package.json | 2 +- .../plugins/kbn_tp_sample_panel_action/package.json | 2 +- x-pack/package.json | 2 +- yarn.lock | 8 ++++---- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 1cec7aaacbbc9..5465b0282fcb9 100644 --- a/package.json +++ b/package.json @@ -116,7 +116,7 @@ "@elastic/charts": "^14.0.0", "@elastic/datemath": "5.0.2", "@elastic/ems-client": "1.0.5", - "@elastic/eui": "17.1.2", + "@elastic/eui": "17.3.0", "@elastic/filesaver": "1.1.2", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "2.3.3", diff --git a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json index 9bd1a02f692ba..6bdb2e4b73041 100644 --- a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json +++ b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.1.2", + "@elastic/eui": "17.3.0", "react": "^16.12.0", "react-dom": "^16.12.0" } diff --git a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json index a3ac52120d69b..29964cca10f20 100644 --- a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json +++ b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.1.2", + "@elastic/eui": "17.3.0", "react": "^16.12.0" } } diff --git a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json index 38fcc950adbe2..b77da4eab8af3 100644 --- a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json +++ b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json @@ -8,7 +8,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.1.2", + "@elastic/eui": "17.3.0", "react": "^16.12.0" }, "scripts": { diff --git a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json index fa8fa3775fa91..053c96e04812e 100644 --- a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json +++ b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json @@ -8,7 +8,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.1.2", + "@elastic/eui": "17.3.0", "react": "^16.12.0" }, "scripts": { diff --git a/x-pack/package.json b/x-pack/package.json index 692f5cf6c4b35..cc944f537b2a5 100644 --- a/x-pack/package.json +++ b/x-pack/package.json @@ -179,7 +179,7 @@ "@elastic/apm-rum-react": "^0.3.2", "@elastic/datemath": "5.0.2", "@elastic/ems-client": "1.0.5", - "@elastic/eui": "17.1.2", + "@elastic/eui": "17.3.0", "@elastic/filesaver": "1.1.2", "@elastic/maki": "6.1.0", "@elastic/node-crypto": "^1.0.0", diff --git a/yarn.lock b/yarn.lock index dff0e9d46e7d8..ed3ae950f32bd 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1433,10 +1433,10 @@ tabbable "^1.1.0" uuid "^3.1.0" -"@elastic/eui@17.1.2": - version "17.1.2" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-17.1.2.tgz#2167ec61ce14c6896844b5ebf890a0b88e0b8c51" - integrity sha512-B0zhJ449fLdjFXED9ibbnx7/ez4M0842O3ZaxbohP7IEIC/oHWhJhWBW0UEtRHlk7tD6uDp4RPjO5GmRKXSLBQ== +"@elastic/eui@17.3.0": + version "17.3.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-17.3.0.tgz#87c4f29a9e56b7640fa7ce1719b142f4d588a6f7" + integrity sha512-hGxjxqFWiRaYARe95cVG2+CrmNCwg4CTxMHYyo14HZZYhlKUdTqintYzEYlc2kC2BgGDu0EvtjnBO7p4luXb3Q== dependencies: "@types/lodash" "^4.14.116" "@types/numeral" "^0.0.25" From 45d7317894cee1962efc6101805ca8fee5e1f80d Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 19 Dec 2019 16:30:13 -0600 Subject: [PATCH 2/5] eui to 17.3.1 --- package.json | 2 +- .../plugins/kbn_tp_run_pipeline/package.json | 2 +- .../plugins/kbn_tp_custom_visualizations/package.json | 2 +- .../plugins/kbn_tp_embeddable_explorer/package.json | 2 +- .../plugins/kbn_tp_sample_panel_action/package.json | 2 +- x-pack/package.json | 2 +- yarn.lock | 8 ++++---- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 5465b0282fcb9..651ffb60d7b88 100644 --- a/package.json +++ b/package.json @@ -116,7 +116,7 @@ "@elastic/charts": "^14.0.0", "@elastic/datemath": "5.0.2", "@elastic/ems-client": "1.0.5", - "@elastic/eui": "17.3.0", + "@elastic/eui": "17.3.1", "@elastic/filesaver": "1.1.2", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "2.3.3", diff --git a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json index 6bdb2e4b73041..02c507dbb3ed8 100644 --- a/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json +++ b/test/interpreter_functional/plugins/kbn_tp_run_pipeline/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.3.0", + "@elastic/eui": "17.3.1", "react": "^16.12.0", "react-dom": "^16.12.0" } diff --git a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json index 29964cca10f20..67ad28c083dbc 100644 --- a/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json +++ b/test/plugin_functional/plugins/kbn_tp_custom_visualizations/package.json @@ -7,7 +7,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.3.0", + "@elastic/eui": "17.3.1", "react": "^16.12.0" } } diff --git a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json index b77da4eab8af3..b22a1ff2d4176 100644 --- a/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json +++ b/test/plugin_functional/plugins/kbn_tp_embeddable_explorer/package.json @@ -8,7 +8,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.3.0", + "@elastic/eui": "17.3.1", "react": "^16.12.0" }, "scripts": { diff --git a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json index 053c96e04812e..8c91826d7b450 100644 --- a/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json +++ b/test/plugin_functional/plugins/kbn_tp_sample_panel_action/package.json @@ -8,7 +8,7 @@ }, "license": "Apache-2.0", "dependencies": { - "@elastic/eui": "17.3.0", + "@elastic/eui": "17.3.1", "react": "^16.12.0" }, "scripts": { diff --git a/x-pack/package.json b/x-pack/package.json index cc944f537b2a5..a90c1ed7f5b53 100644 --- a/x-pack/package.json +++ b/x-pack/package.json @@ -179,7 +179,7 @@ "@elastic/apm-rum-react": "^0.3.2", "@elastic/datemath": "5.0.2", "@elastic/ems-client": "1.0.5", - "@elastic/eui": "17.3.0", + "@elastic/eui": "17.3.1", "@elastic/filesaver": "1.1.2", "@elastic/maki": "6.1.0", "@elastic/node-crypto": "^1.0.0", diff --git a/yarn.lock b/yarn.lock index ed3ae950f32bd..7528db731e587 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1433,10 +1433,10 @@ tabbable "^1.1.0" uuid "^3.1.0" -"@elastic/eui@17.3.0": - version "17.3.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-17.3.0.tgz#87c4f29a9e56b7640fa7ce1719b142f4d588a6f7" - integrity sha512-hGxjxqFWiRaYARe95cVG2+CrmNCwg4CTxMHYyo14HZZYhlKUdTqintYzEYlc2kC2BgGDu0EvtjnBO7p4luXb3Q== +"@elastic/eui@17.3.1": + version "17.3.1" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-17.3.1.tgz#67d883207b2efdb9a48f2d949b95de1e4bbc1064" + integrity sha512-fYoPbRXr9mZlTcfSqOCE65yb2Zpsptq4Y1Lg8+aeMw8G5JpMnUx1RaBRe1OJrCRHWpuF0f8Yxg+i1DDqxxLnlA== dependencies: "@types/lodash" "^4.14.116" "@types/numeral" "^0.0.25" From 9768d70d9ba82ff385bb14c7a12d0ef80f18c7e5 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Thu, 19 Dec 2019 16:37:50 -0600 Subject: [PATCH 3/5] TS updates --- .../static/forms/components/fields/numeric_field.tsx | 4 ++-- .../public/components/inputs/multi_input.tsx | 5 ++++- .../public/components/inputs/password_input.tsx | 6 ++++-- .../public/components/layouts/walkthrough.tsx | 8 +------- .../public/components/field_manager/field_editor.tsx | 1 - .../dimension_panel/field_select.tsx | 5 +---- .../operations/definitions/date_histogram.tsx | 6 +++++- .../space_aware_privilege_section/space_selector.tsx | 8 +------- .../public/components/fields_browser/field_name.tsx | 1 - .../components/tabs/checkup/checkup_tab.tsx | 2 -- .../application/components/tabs/overview/index.tsx | 2 -- .../json_watch_edit/json_watch_edit_simulate.tsx | 12 ++++++++++-- 12 files changed, 28 insertions(+), 32 deletions(-) diff --git a/src/plugins/es_ui_shared/static/forms/components/fields/numeric_field.tsx b/src/plugins/es_ui_shared/static/forms/components/fields/numeric_field.tsx index ad8c006438c3e..92f697f6ae73a 100644 --- a/src/plugins/es_ui_shared/static/forms/components/fields/numeric_field.tsx +++ b/src/plugins/es_ui_shared/static/forms/components/fields/numeric_field.tsx @@ -18,7 +18,7 @@ */ import React from 'react'; -import { EuiFormRow, EuiFieldNumber } from '@elastic/eui'; +import { EuiFormRow, EuiFieldNumber, EuiFieldNumberProps } from '@elastic/eui'; import { FieldHook, getFieldValidityAndErrorMessage } from '../../hook_form_lib'; @@ -44,7 +44,7 @@ export const NumericField = ({ field, euiFieldProps = {}, ...rest }: Props) => { > { instantValidation: boolean; label: string; errorText: string; diff --git a/x-pack/legacy/plugins/beats_management/public/components/inputs/password_input.tsx b/x-pack/legacy/plugins/beats_management/public/components/inputs/password_input.tsx index 30318f76bb90f..30f4cb85fb58c 100644 --- a/x-pack/legacy/plugins/beats_management/public/components/inputs/password_input.tsx +++ b/x-pack/legacy/plugins/beats_management/public/components/inputs/password_input.tsx @@ -4,12 +4,14 @@ * you may not use this file except in compliance with the Elastic License. */ -// @ts-ignore currently no definition for EuiFieldPassword import { CommonProps, EuiFieldPassword, EuiFieldPasswordProps, EuiFormRow } from '@elastic/eui'; import { FormsyInputProps, withFormsy } from 'formsy-react'; import React, { Component, InputHTMLAttributes } from 'react'; -interface ComponentProps extends FormsyInputProps, CommonProps, EuiFieldPasswordProps { +interface ComponentProps + extends FormsyInputProps, + CommonProps, + Omit { instantValidation?: boolean; label: string; errorText: string; diff --git a/x-pack/legacy/plugins/beats_management/public/components/layouts/walkthrough.tsx b/x-pack/legacy/plugins/beats_management/public/components/layouts/walkthrough.tsx index bcedfc063b0e5..bf065a66eda26 100644 --- a/x-pack/legacy/plugins/beats_management/public/components/layouts/walkthrough.tsx +++ b/x-pack/legacy/plugins/beats_management/public/components/layouts/walkthrough.tsx @@ -6,13 +6,7 @@ import React from 'react'; -import { - EuiPageContent, - EuiPageContentBody, - // @ts-ignore - EuiStepsHorizontal, - EuiTitle, -} from '@elastic/eui'; +import { EuiPageContent, EuiPageContentBody, EuiStepsHorizontal, EuiTitle } from '@elastic/eui'; interface LayoutProps { title: string; diff --git a/x-pack/legacy/plugins/graph/public/components/field_manager/field_editor.tsx b/x-pack/legacy/plugins/graph/public/components/field_manager/field_editor.tsx index 5ece430e60c26..6152f33350917 100644 --- a/x-pack/legacy/plugins/graph/public/components/field_manager/field_editor.tsx +++ b/x-pack/legacy/plugins/graph/public/components/field_manager/field_editor.tsx @@ -12,7 +12,6 @@ import { EuiComboBox, EuiColorPicker, EuiFieldNumber, - // @ts-ignore EuiHighlight, EuiContextMenu, EuiIcon, diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/field_select.tsx b/x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/field_select.tsx index ba18cd150c7a5..46d7233ba9587 100644 --- a/x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/field_select.tsx +++ b/x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/field_select.tsx @@ -9,10 +9,7 @@ import React, { useMemo } from 'react'; import { i18n } from '@kbn/i18n'; import { EuiComboBox, EuiFlexGroup, EuiFlexItem, EuiComboBoxOptionProps } from '@elastic/eui'; import classNames from 'classnames'; -import { - // @ts-ignore - EuiHighlight, -} from '@elastic/eui'; +import { EuiHighlight } from '@elastic/eui'; import { OperationType } from '../indexpattern'; import { LensFieldIcon } from '../lens_field_icon'; import { DataType } from '../../types'; diff --git a/x-pack/legacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.tsx b/x-pack/legacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.tsx index 944a23c9af193..0bb653ac1e0c2 100644 --- a/x-pack/legacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.tsx +++ b/x-pack/legacy/plugins/lens/public/indexpattern_plugin/operations/definitions/date_histogram.tsx @@ -208,7 +208,11 @@ export const dateHistogramOperation: OperationDefinition { diff --git a/x-pack/legacy/plugins/security/public/views/management/edit_role/components/privileges/kibana/space_aware_privilege_section/space_selector.tsx b/x-pack/legacy/plugins/security/public/views/management/edit_role/components/privileges/kibana/space_aware_privilege_section/space_selector.tsx index 75211498c57b8..e6e206e5fc7f4 100644 --- a/x-pack/legacy/plugins/security/public/views/management/edit_role/components/privileges/kibana/space_aware_privilege_section/space_selector.tsx +++ b/x-pack/legacy/plugins/security/public/views/management/edit_role/components/privileges/kibana/space_aware_privilege_section/space_selector.tsx @@ -4,13 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ -import { - EuiComboBox, - EuiComboBoxOptionProps, - EuiHealth, - // @ts-ignore - EuiHighlight, -} from '@elastic/eui'; +import { EuiComboBox, EuiComboBoxOptionProps, EuiHealth, EuiHighlight } from '@elastic/eui'; import { InjectedIntl } from '@kbn/i18n/react'; import React, { Component } from 'react'; import { Space } from '../../../../../../../../../spaces/common/model/space'; diff --git a/x-pack/legacy/plugins/siem/public/components/fields_browser/field_name.tsx b/x-pack/legacy/plugins/siem/public/components/fields_browser/field_name.tsx index a2182b14cdbc3..b8fbe46baa9c5 100644 --- a/x-pack/legacy/plugins/siem/public/components/fields_browser/field_name.tsx +++ b/x-pack/legacy/plugins/siem/public/components/fields_browser/field_name.tsx @@ -6,7 +6,6 @@ import { EuiButtonIcon, - // @ts-ignore EuiHighlight, EuiIcon, EuiFlexGroup, diff --git a/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/checkup_tab.tsx b/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/checkup_tab.tsx index 9aa40663125ae..14f56157068e6 100644 --- a/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/checkup_tab.tsx +++ b/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/checkup_tab.tsx @@ -8,8 +8,6 @@ import { find } from 'lodash'; import React, { Fragment } from 'react'; import { - // @ts-ignore - EuiAccordion, EuiCallOut, EuiEmptyPrompt, EuiLink, diff --git a/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/overview/index.tsx b/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/overview/index.tsx index 0a05743d1623d..284265bb31f14 100644 --- a/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/overview/index.tsx +++ b/x-pack/legacy/plugins/upgrade_assistant/public/np_ready/application/components/tabs/overview/index.tsx @@ -13,8 +13,6 @@ import { EuiPageContent, EuiPageContentBody, EuiSpacer, - // @ts-ignore - EuiStat, EuiText, } from '@elastic/eui'; import { FormattedMessage } from '@kbn/i18n/react'; diff --git a/x-pack/legacy/plugins/watcher/public/np_ready/application/sections/watch_edit/components/json_watch_edit/json_watch_edit_simulate.tsx b/x-pack/legacy/plugins/watcher/public/np_ready/application/sections/watch_edit/components/json_watch_edit/json_watch_edit_simulate.tsx index 7c5de3d8e9298..9ea2b3bcd1e9a 100644 --- a/x-pack/legacy/plugins/watcher/public/np_ready/application/sections/watch_edit/components/json_watch_edit/json_watch_edit_simulate.tsx +++ b/x-pack/legacy/plugins/watcher/public/np_ready/application/sections/watch_edit/components/json_watch_edit/json_watch_edit_simulate.tsx @@ -186,7 +186,11 @@ export const JsonWatchEditSimulate = ({ { @@ -225,7 +229,11 @@ export const JsonWatchEditSimulate = ({ )} > Date: Thu, 19 Dec 2019 16:42:18 -0600 Subject: [PATCH 4/5] snapshot updates --- .../fatal_errors_screen.test.tsx.snap | 7 +- .../list_control_editor.test.tsx.snap | 9 -- .../range_control_editor.test.tsx.snap | 6 -- .../dashboard_empty_screen.test.tsx.snap | 12 +-- .../__snapshots__/save_modal.test.js.snap | 2 - .../__snapshots__/home.test.js.snap | 20 ---- .../__snapshots__/tutorial.test.js.snap | 15 +-- .../__snapshots__/objects_table.test.js.snap | 1 - .../field/__snapshots__/field.test.js.snap | 10 -- .../splits/__snapshots__/terms.test.js.snap | 3 - .../__snapshots__/duration.test.js.snap | 3 - .../__snapshots__/truncate.test.js.snap | 3 - .../url/__snapshots__/url.test.js.snap | 6 -- .../extended_bounds.test.tsx.snap | 2 - .../controls/__snapshots__/size.test.tsx.snap | 1 - .../__snapshots__/number_row.test.tsx.snap | 1 - .../saved_object_save_modal.test.tsx.snap | 2 - .../__test__/__snapshots__/List.test.tsx.snap | 2 - .../upload_license.test.tsx.snap | 5 - .../pipeline_editor.test.js.snap | 96 ------------------- .../upgrade_failure.test.js.snap | 16 +--- .../condition_expression.test.js.snap | 6 -- .../edit_condition_link.test.js.snap | 6 -- .../__snapshots__/overrides.test.js.snap | 3 - .../__snapshots__/editor.test.tsx.snap | 2 - .../__snapshots__/new_calendar.test.js.snap | 2 - .../__snapshots__/calendars_list.test.js.snap | 2 - .../add_item_popover.test.js.snap | 6 -- .../edit_filter_list.test.js.snap | 16 ---- .../__snapshots__/filter_lists.test.js.snap | 2 - .../__snapshots__/overview.test.js.snap | 26 ++--- .../ccr/__snapshots__/ccr.test.js.snap | 13 +-- .../__snapshots__/ccr_shard.test.js.snap | 6 +- .../pipeline_viewer.test.js.snap | 20 +--- .../api_keys_grid_page.test.tsx.snap | 1 - .../roles_grid_page.test.tsx.snap | 1 - .../note_card_body.test.tsx.snap | 2 +- .../__snapshots__/index.test.tsx.snap | 2 +- .../spaces_grid_pages.test.tsx.snap | 1 - .../space_selector.test.tsx.snap | 8 +- .../__snapshots__/checkup_tab.test.tsx.snap | 12 +-- 41 files changed, 30 insertions(+), 329 deletions(-) diff --git a/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap b/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap index 08b72c35ee2d3..b9a4f775c2b56 100644 --- a/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap +++ b/src/core/public/fatal_errors/__snapshots__/fatal_errors_screen.test.tsx.snap @@ -2,20 +2,15 @@ exports[`rendering render matches snapshot 1`] = ` - + @@ -58,10 +55,7 @@ exports[`renders RangeControlEditor 1`] = ` labelType="label" > - +
- +
diff --git a/src/legacy/core_plugins/kibana/public/home/components/__snapshots__/home.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/__snapshots__/home.test.js.snap index c1131cbe559f6..4563b633c3dfc 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/__snapshots__/home.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/__snapshots__/home.test.js.snap @@ -7,8 +7,6 @@ exports[`home directories should not render directory entry when showOnHomePage >

@@ -123,8 +121,6 @@ exports[`home directories should render ADMIN directory entry in "Manage" panel >

@@ -252,8 +248,6 @@ exports[`home directories should render DATA directory entry in "Explore Data" p >

@@ -381,8 +375,6 @@ exports[`home isNewKibanaInstance should safely handle execeptions 1`] = ` >

@@ -497,8 +489,6 @@ exports[`home isNewKibanaInstance should set isNewKibanaInstance to false when t >

@@ -613,8 +603,6 @@ exports[`home isNewKibanaInstance should set isNewKibanaInstance to true when th >

@@ -729,8 +717,6 @@ exports[`home should render home component 1`] = ` >

@@ -845,8 +831,6 @@ exports[`home welcome should show the normal home page if loading fails 1`] = ` >

@@ -961,8 +945,6 @@ exports[`home welcome should show the normal home page if welcome screen is disa >

@@ -1085,8 +1067,6 @@ exports[`home welcome stores skip welcome setting if skipped 1`] = ` >

diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/tutorial.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/tutorial.test.js.snap index db286fb4d2fee..3fe75c22f3fc5 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/tutorial.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/tutorial.test.js.snap @@ -4,10 +4,7 @@ exports[`isCloudEnabled is false should not render instruction toggle when ON_PR - +
- +
- +
diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/duration/__snapshots__/duration.test.js.snap b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/duration/__snapshots__/duration.test.js.snap index b4493a6b5557b..9722a01986434 100644 --- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/duration/__snapshots__/duration.test.js.snap +++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/duration/__snapshots__/duration.test.js.snap @@ -210,10 +210,7 @@ exports[`DurationFormatEditor should render non-human readable output normally 1 labelType="label" > diff --git a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/url/__snapshots__/url.test.js.snap b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/url/__snapshots__/url.test.js.snap index 3e1d45095e251..4b246fecb8146 100644 --- a/src/legacy/ui/public/field_editor/components/field_format_editor/editors/url/__snapshots__/url.test.js.snap +++ b/src/legacy/ui/public/field_editor/components/field_format_editor/editors/url/__snapshots__/url.test.js.snap @@ -534,10 +534,7 @@ exports[`UrlFormatEditor should render width and height fields if image 1`] = ` labelType="label" > @@ -558,10 +555,7 @@ exports[`UrlFormatEditor should render width and height fields if image 1`] = ` labelType="label" > diff --git a/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/extended_bounds.test.tsx.snap b/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/extended_bounds.test.tsx.snap index 37783dc01492d..25824c3b59fb0 100644 --- a/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/extended_bounds.test.tsx.snap +++ b/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/extended_bounds.test.tsx.snap @@ -21,7 +21,6 @@ exports[`ExtendedBoundsParamEditor should be rendered with default set of props compressed={true} fullWidth={true} isInvalid={false} - isLoading={false} onChange={[Function]} prepend="Min" value="" @@ -33,7 +32,6 @@ exports[`ExtendedBoundsParamEditor should be rendered with default set of props compressed={true} fullWidth={true} isInvalid={false} - isLoading={false} onChange={[Function]} prepend="Max" value="" diff --git a/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/size.test.tsx.snap b/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/size.test.tsx.snap index 024865ec733d6..a2897ad417bae 100644 --- a/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/size.test.tsx.snap +++ b/src/legacy/ui/public/vis/editors/default/controls/__snapshots__/size.test.tsx.snap @@ -25,7 +25,6 @@ exports[`SizeParamEditor should init with the default set of props 1`] = ` data-test-subj="sizeParamEditor" fullWidth={true} isInvalid={false} - isLoading={false} min={1} onBlur={[MockFunction]} onChange={[Function]} diff --git a/src/legacy/ui/public/vis/editors/default/controls/components/number_list/__snapshots__/number_row.test.tsx.snap b/src/legacy/ui/public/vis/editors/default/controls/components/number_list/__snapshots__/number_row.test.tsx.snap index 3882425594cf3..6b2f160e417a0 100644 --- a/src/legacy/ui/public/vis/editors/default/controls/components/number_list/__snapshots__/number_row.test.tsx.snap +++ b/src/legacy/ui/public/vis/editors/default/controls/components/number_list/__snapshots__/number_row.test.tsx.snap @@ -13,7 +13,6 @@ exports[`NumberRow should be rendered with default set of props 1`] = ` compressed={true} fullWidth={true} isInvalid={false} - isLoading={false} max={10} min={1} onBlur={[MockFunction]} diff --git a/src/plugins/kibana_react/public/saved_objects/__snapshots__/saved_object_save_modal.test.tsx.snap b/src/plugins/kibana_react/public/saved_objects/__snapshots__/saved_object_save_modal.test.tsx.snap index 3c0393b12febd..978705a3ad096 100644 --- a/src/plugins/kibana_react/public/saved_objects/__snapshots__/saved_object_save_modal.test.tsx.snap +++ b/src/plugins/kibana_react/public/saved_objects/__snapshots__/saved_object_save_modal.test.tsx.snap @@ -69,9 +69,7 @@ exports[`SavedObjectSaveModal should render matching snapshot 1`] = ` > diff --git a/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap b/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap index 9358eeceb1a44..492d28206f3dd 100644 --- a/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap +++ b/x-pack/legacy/plugins/apm/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap @@ -74,7 +74,6 @@ exports[`ErrorGroupOverview -> List should render empty state 1`] = ` >
List should render with data 1`] = ` >
@@ -153,10 +149,7 @@ Default value: Number of the host’s CPU cores" Default value: 125" > @@ -168,10 +161,7 @@ Default value: 125" Default value: 50ms" > @@ -215,10 +205,7 @@ Default value: memory" Default value: 1024mb (1g)" > @@ -273,10 +260,7 @@ Default value: 1024mb (1g)" Default value: 1024" > @@ -330,7 +314,6 @@ exports[`PipelineEditor component invalidates form for invalid pipeline id input > @@ -476,10 +456,7 @@ Default value: Number of the host’s CPU cores" Default value: 125" > @@ -491,10 +468,7 @@ Default value: 125" Default value: 50ms" > @@ -538,10 +512,7 @@ Default value: memory" Default value: 1024mb (1g)" > @@ -596,10 +567,7 @@ Default value: 1024mb (1g)" Default value: 1024" > @@ -653,7 +621,6 @@ exports[`PipelineEditor component invalidates form for pipeline id with spaces 1 > @@ -799,10 +763,7 @@ Default value: Number of the host’s CPU cores" Default value: 125" > @@ -814,10 +775,7 @@ Default value: 125" Default value: 50ms" > @@ -861,10 +819,7 @@ Default value: memory" Default value: 1024mb (1g)" > @@ -919,10 +874,7 @@ Default value: 1024mb (1g)" Default value: 1024" > @@ -976,7 +928,6 @@ exports[`PipelineEditor component matches snapshot for clone pipeline 1`] = ` > @@ -1091,10 +1039,7 @@ Default value: Number of the host’s CPU cores" Default value: 125" > @@ -1106,10 +1051,7 @@ Default value: 125" Default value: 50ms" > @@ -1153,10 +1095,7 @@ Default value: memory" Default value: 1024mb (1g)" > @@ -1211,10 +1150,7 @@ Default value: 1024mb (1g)" Default value: 1024" > @@ -1283,7 +1219,6 @@ exports[`PipelineEditor component matches snapshot for create pipeline 1`] = ` > @@ -1425,10 +1357,7 @@ Default value: Number of the host’s CPU cores" Default value: 125" > @@ -1440,10 +1369,7 @@ Default value: 125" Default value: 50ms" > @@ -1487,10 +1413,7 @@ Default value: memory" Default value: 1024mb (1g)" > @@ -1545,10 +1468,7 @@ Default value: 1024mb (1g)" Default value: 1024" > @@ -1602,7 +1522,6 @@ exports[`PipelineEditor component matches snapshot for edit pipeline 1`] = ` > @@ -1717,10 +1633,7 @@ Default value: Number of the host’s CPU cores" Default value: 125" > @@ -1732,10 +1645,7 @@ Default value: 125" Default value: 50ms" > @@ -1779,10 +1689,7 @@ Default value: memory" Default value: 1024mb (1g)" > @@ -1837,10 +1744,7 @@ Default value: 1024mb (1g)" Default value: 1024" > diff --git a/x-pack/legacy/plugins/logstash/public/components/upgrade_failure/__snapshots__/upgrade_failure.test.js.snap b/x-pack/legacy/plugins/logstash/public/components/upgrade_failure/__snapshots__/upgrade_failure.test.js.snap index 5cb5a6e2def6b..07ae9fb2e06c7 100644 --- a/x-pack/legacy/plugins/logstash/public/components/upgrade_failure/__snapshots__/upgrade_failure.test.js.snap +++ b/x-pack/legacy/plugins/logstash/public/components/upgrade_failure/__snapshots__/upgrade_failure.test.js.snap @@ -117,9 +117,7 @@ exports[`UpgradeFailure component passes expected text for new pipeline 1`] = ` } } > - + - + - + - + @@ -392,9 +389,6 @@ exports[`ConditionExpression renders with only value supplied 1`] = ` } > diff --git a/x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/__snapshots__/edit_condition_link.test.js.snap b/x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/__snapshots__/edit_condition_link.test.js.snap index ba44032afb3c2..a367dd82a91ab 100644 --- a/x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/__snapshots__/edit_condition_link.test.js.snap +++ b/x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/__snapshots__/edit_condition_link.test.js.snap @@ -27,8 +27,6 @@ exports[`EditConditionLink renders for a condition using actual 1`] = ` diff --git a/x-pack/legacy/plugins/ml/public/application/jobs/components/custom_url_editor/__snapshots__/editor.test.tsx.snap b/x-pack/legacy/plugins/ml/public/application/jobs/components/custom_url_editor/__snapshots__/editor.test.tsx.snap index d98dcb26ee238..c5fd0ea63c71d 100644 --- a/x-pack/legacy/plugins/ml/public/application/jobs/components/custom_url_editor/__snapshots__/editor.test.tsx.snap +++ b/x-pack/legacy/plugins/ml/public/application/jobs/components/custom_url_editor/__snapshots__/editor.test.tsx.snap @@ -1019,7 +1019,6 @@ exports[`CustomUrlEditor renders the editor for other type of URL with duplicate compressed={true} fullWidth={true} onChange={[Function]} - resize="vertical" rows={2} value="https://www.google.co.uk/search?q=airline+code+$airline$" /> @@ -1135,7 +1134,6 @@ exports[`CustomUrlEditor renders the editor for other type of URL with unique la compressed={true} fullWidth={true} onChange={[Function]} - resize="vertical" rows={2} value="https://www.google.co.uk/search?q=airline+code+$airline$" /> diff --git a/x-pack/legacy/plugins/ml/public/application/settings/calendars/edit/__snapshots__/new_calendar.test.js.snap b/x-pack/legacy/plugins/ml/public/application/settings/calendars/edit/__snapshots__/new_calendar.test.js.snap index 9a48bb551dcde..e8219f5fa6f94 100644 --- a/x-pack/legacy/plugins/ml/public/application/settings/calendars/edit/__snapshots__/new_calendar.test.js.snap +++ b/x-pack/legacy/plugins/ml/public/application/settings/calendars/edit/__snapshots__/new_calendar.test.js.snap @@ -7,12 +7,10 @@ exports[`NewCalendar Renders new calendar form 1`] = ` /> @@ -133,9 +131,7 @@ exports[`AddItemPopover opens the popover onButtonClick 1`] = ` labelType="label" > @@ -220,9 +216,7 @@ exports[`AddItemPopover renders the popover 1`] = ` labelType="label" > diff --git a/x-pack/legacy/plugins/ml/public/application/settings/filter_lists/edit/__snapshots__/edit_filter_list.test.js.snap b/x-pack/legacy/plugins/ml/public/application/settings/filter_lists/edit/__snapshots__/edit_filter_list.test.js.snap index f5149bf857adc..17986d838ec5e 100644 --- a/x-pack/legacy/plugins/ml/public/application/settings/filter_lists/edit/__snapshots__/edit_filter_list.test.js.snap +++ b/x-pack/legacy/plugins/ml/public/application/settings/filter_lists/edit/__snapshots__/edit_filter_list.test.js.snap @@ -7,12 +7,10 @@ exports[`EditFilterList adds new items to filter list 1`] = ` /> - - + + + @@ -199,16 +192,9 @@ exports[`Overview that overview page renders normally 1`] = ` `; exports[`Overview that overview page shows a message if there is no beats data 1`] = ` - - - + + + diff --git a/x-pack/legacy/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap b/x-pack/legacy/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap index da83a4d7def14..bb765d0ab7b4e 100644 --- a/x-pack/legacy/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap +++ b/x-pack/legacy/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap @@ -1,16 +1,9 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`Ccr that it renders normally 1`] = ` - - - + + + - + - + + - + + renders permission denied if required 1`] = ` > - + - + - + - + Date: Fri, 20 Dec 2019 10:05:25 -0600 Subject: [PATCH 5/5] update data-test-subj --- test/functional/page_objects/settings_page.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/page_objects/settings_page.js b/test/functional/page_objects/settings_page.js index a3c198b179bda..a4ae361b12ed8 100644 --- a/test/functional/page_objects/settings_page.js +++ b/test/functional/page_objects/settings_page.js @@ -547,7 +547,7 @@ export function SettingsPageProvider({ getService, getPageObjects }) { async setScriptedFieldScript(script) { log.debug('set scripted field script = ' + script); - const aceEditorCssSelector = '[data-test-subj="codeEditorContainer"] .ace_editor'; + const aceEditorCssSelector = '[data-test-subj="editorFieldScript"] .ace_editor'; await find.clickByCssSelector(aceEditorCssSelector); for (let i = 0; i < 1000; i++) { await browser.pressKeys(browser.keys.BACK_SPACE);