[ML] Data frame analytics: Advanced editor. #43989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
release_note:enhancement
:ml
v8.0.0
v7.4.0
Feature:Data Frame Analytics
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
jgowdyelastic
approved these changes
Aug 27, 2019
...data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx
Outdated
Show resolved
Hide resolved
...c/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/actions.ts
Outdated
Show resolved
Hide resolved
..._management/components/create_analytics_advanced_editor/create_analytics_advanced_editor.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
A couple of minor comments on the use of id and one of the action labels.
I think it would be useful to expose the model_memory_limit as a setting in the editor. This should be given a reasonable (fixed) default for now - suggest 50MB. Then for 7.5 we should look at passing the config to the new endpoint to pre-populate this field with a sensible default - see #43740. Could an extra field also be added to the form editor for the model memory limit?
...c/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/actions.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
|
@peteharverson In 1888b6e for both the form and advanced editor the default memory limit is set to |
|
I'm seeing some strange behavior when using the advanced editor
That behavior ^^ is accompanied by this error in the console:
|
alvarezmelissa87
requested changes
Aug 27, 2019
|
@alvarezmelissa87 oh so sorry - looks like I missed saving one file change so it looked ok in my editor but git didn't pick it up :( - I just pushed the missing bit can you please try again? |
|
Tested again with latest updates and works as expected 🙌 Thanks, @walterra |
alvarezmelissa87
approved these changes
Aug 27, 2019
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Aug 28, 2019
Adds an option to switch to an advanced (JSON) editor when creating an analytics job. This builds upon the previous work for the modal for analytics job creation and the use of useReducer(): - The files of the custom hook useCreateAnalyticsForm() have been further split up and there's now separate actions.ts and state.ts files. - To only allow updating what's really related to the form value's state via setFormState, the state structure has been updated and more fine grained actions have been added. - The user can enabled the advanced editor, but cannot move back to the original form (there's a help text in the UI about that). - The advanced editor component's (CreateAnalyticsAdvancedEditor) structure is based on the regular form, it still has an input field for the job ID and the toggle for optionally creating an index pattern. The fields for source/destination index are replaced by an editable JSON textarea input. - The advanced editor features mostly the same validation like the regular form. For example, if the source index isn't valid, an error will be shown in a CallOut below the editable area.
walterra
added a commit
that referenced
this pull request
Aug 29, 2019
Adds an option to switch to an advanced (JSON) editor when creating an analytics job. This builds upon the previous work for the modal for analytics job creation and the use of useReducer(): - The files of the custom hook useCreateAnalyticsForm() have been further split up and there's now separate actions.ts and state.ts files. - To only allow updating what's really related to the form value's state via setFormState, the state structure has been updated and more fine grained actions have been added. - The user can enabled the advanced editor, but cannot move back to the original form (there's a help text in the UI about that). - The advanced editor component's (CreateAnalyticsAdvancedEditor) structure is based on the regular form, it still has an input field for the job ID and the toggle for optionally creating an index pattern. The fields for source/destination index are replaced by an editable JSON textarea input. - The advanced editor features mostly the same validation like the regular form. For example, if the source index isn't valid, an error will be shown in a CallOut below the editable area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an option to switch to an advanced (JSON) editor when creating an analytics job.
This builds upon the previous work for the modal for analytics job creation and the use of
useReducer():useCreateAnalyticsForm()have been further split up and there's now separateactions.tsandstate.tsfiles.setFormState, the state structure has been updated and more fine grained actions have been added.CreateAnalyticsAdvancedEditor) structure is based on the regular form, it still has an input field for thejob IDand the toggle for optionally creating an index pattern. The fields for source/destination index are replaced by an editable JSON textarea input.CallOutbelow the editable area.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Documentation was added for features that require explanation or tutorialsFor maintainers