Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List grunt tasks from terminal #43798

Merged
merged 4 commits into from
Aug 27, 2019
Merged

List grunt tasks from terminal #43798

merged 4 commits into from
Aug 27, 2019

Conversation

wayneseymour
Copy link
Member

Now you can run
$ grunt tasks Lists available tasks

$ grunt tasks
# Lists available tasks :)
@wayneseymour wayneseymour added dev release_note:skip Skip the PR/issue when compiling release notes labels Aug 22, 2019
@wayneseymour wayneseymour requested a review from spalger August 22, 2019 17:56
@elasticmachine
Copy link
Contributor

💔 Build Failed

@wayneseymour
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM. Make sense from my perspective, but I think it is up to Kibana OpsTeam to decide.

@wayneseymour wayneseymour added the Team:Operations Team label for Operations Team label Aug 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@wayneseymour wayneseymour requested a review from jbudz August 26, 2019 18:03
@jbudz
Copy link
Member

jbudz commented Aug 26, 2019

Works for me - can we move the tasks and config in gruntfile to the tasks/ folder to, consistent with the other tasks?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@wayneseymour
Copy link
Member Author

Works for me - can we move the tasks and config in gruntfile to the tasks/ folder to, consistent with the other tasks?

Why certainly! :)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@wayneseymour
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@wayneseymour wayneseymour self-assigned this Aug 27, 2019
@wayneseymour wayneseymour merged commit 4d1671b into master Aug 27, 2019
@tylersmalley
Copy link
Contributor

Remember to tag with the versions your merging into. Thanks.

@wayneseymour
Copy link
Member Author

Remember to tag with the versions your merging into. Thanks.

You mean for the backport?

@wayneseymour
Copy link
Member Author

Backport (to 7.x) bombing @spalger
I ran yarn kbn:bootstrap in the affected dir and this is the result:

yarn kbn:bootstrap
yarn run v1.16.0
$ yarn build
$ tsc
src/proc_runner/proc.ts:103:7 - error TS2345: Argument of type 'MonoTypeOperatorFunction<unknown>' is not assignable to parameter of type 'OperatorFunction<unknown, [number]>'.
  Type 'Observable<unknown>' is not assignable to type 'Observable<[number]>'.
    Type 'unknown' is not assignable to type '[number]'.

103       take(1),
          ~~~~~~~

src/proc_runner/proc.ts:122:10 - error TS2345: Argument of type 'MonoTypeOperatorFunction<number | null>' is not assignable to parameter of type 'OperatorFunction<unknown, number | null>'.
  Types of parameters 'source' and 'source' are incompatible.
    Type 'Observable<unknown>' is not assignable to type 'Observable<number | null>'.
      Type 'unknown' is not assignable to type 'number | null'.
        Type 'unknown' is not assignable to type 'number'.

122   ).pipe(share());
             ~~~~~~~

src/proc_runner/proc.ts:144:47 - error TS2554: Expected 1 arguments, but got 2.

144         await treeKillAsync(childProcess.pid, signal);
                                                  ~~~~~~

src/proc_runner/proc.ts:152:47 - error TS2554: Expected 1 arguments, but got 2.

152         await treeKillAsync(childProcess.pid, 'SIGKILL');
                                                  ~~~~~~~~~


Found 4 errors.

error Command failed with exit code 2.

yarn kbn clean && yarn kbn:bootstrap does not bomb on master

wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Aug 30, 2019
* Add ability to run
$ grunt tasks

* Move conf and task to config per review
wayneseymour added a commit that referenced this pull request Aug 30, 2019
* Add ability to run
`$ grunt tasks`

* Move conf and task to config per review
wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Aug 30, 2019
* Add ability to run
$ grunt tasks

* Move conf and task to config per review
wayneseymour added a commit that referenced this pull request Aug 30, 2019
* Add ability to run
`$ grunt tasks`

* Move conf and task to config per review
@wayneseymour wayneseymour deleted the add-grunt-available-tasks branch April 15, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants