Skipping the privileges api integration test #36142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
non-issue
|
Pinging @elastic/kibana-security |
💚 Build Succeeded |
legrego
approved these changes
May 7, 2019
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
May 9, 2019
kobelb
added a commit
that referenced
this pull request
May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api tests for
/api/security/privilegescurrently have to be updated as new features are added or whenever a number of changes are made to existing features. This is a burden to the consuming application teams, and provides them very little benefit.The security team still sees some benefit from these tests when checking the infrastructure which calculated these privileges; however, we can selectively only run these tests when they benefit us. Hence the skip instead of just deleting the tests entirely.
If we get to the point where we're able to use jest's snapshotting, there's potential that the burden will be low enough to reintroduce this test and always have it run. The downsides just out weigh the benefits at this point in time.