Remove (most of) Angular dependecies from filter bar #35544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 24, 2019 19:25
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
lizozom
force-pushed
the
newplatform/data-plugin/filter-bar-1
branch
2 times, most recently
from
15675db to
58b2289
Compare
lizozom
force-pushed
the
newplatform/data-plugin/filter-bar-1
branch
from
58b2289 to
d399e4b
Compare
💔 Build Failed |
…plugin/filter-bar-1
💔 Build Failed |
added 3 commits
April 30, 2019 16:10
…plugin/filter-bar-1
…plugin/filter-bar-1
💚 Build Succeeded |
lizozom
changed the title
lizozom
changed the title
lizozom
commented
May 1, 2019
lizozom
added
Feature:New Platform
v7.2.0
v8.0.0
:AppArch
release_note:skip
|
Pinging @elastic/kibana-app-arch |
|
@Bargs this PR shouldn't have the digestion problems you saw with the previous version. |
…plugin/filter-bar-1
💚 Build Succeeded |
lizozom
commented
May 2, 2019
added 2 commits
May 5, 2019 10:36
💚 Build Succeeded |
mattkime
approved these changes
May 6, 2019
lukeelmers
approved these changes
May 6, 2019
There was a problem hiding this comment.
Seeing all these providers go away is SO GREAT. Thanks for sorting all of this out! 🙌 💪
Since we're technically breaking some interfaces, I'm wondering if any of these changes are going to need to be published in our dev docs. I'm not sure how likely it is that downstream devs will have code relying on these legacy Providers.
Any thoughts on that? Would also be curious what @ppisljar or @timroes think.
src/legacy/ui/public/filter_bar/lib/__tests__/map_query_string.js
Outdated
Show resolved
Hide resolved
added 2 commits
May 7, 2019 10:08
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
May 7, 2019
* Cleaned up usage of angular dependencies from apply filters \ filter bar * Cleaned up usage of angular dependencies from exact time filter * Removed unused Private from EventsProvider * Deleted unused push_filter * Changed push filters not to be a provider * Renamed mapper functions
lizozom
pushed a commit
that referenced
this pull request
May 7, 2019
* Cleaned up usage of angular dependencies from apply filters \ filter bar * Cleaned up usage of angular dependencies from exact time filter * Removed unused Private from EventsProvider * Deleted unused push_filter * Changed push filters not to be a provider * Renamed mapper functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove most of Angular dependecies from filter bar.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers