From ae76dc6dcce5c1f209f505b2b3fd2548afcc478e Mon Sep 17 00:00:00 2001 From: Tim Roes Date: Wed, 26 Sep 2018 10:39:27 +0200 Subject: [PATCH] Remove last mentions of spy panels --- docs/setup/settings.asciidoc | 2 +- src/ui/public/inspector/types.ts | 2 +- src/ui/public/vis/request_handlers/courier.js | 2 +- .../public/visualize/loader/__tests__/visualize_loader.js | 6 ------ test/functional/apps/visualize/_tile_map.js | 2 -- 5 files changed, 3 insertions(+), 11 deletions(-) diff --git a/docs/setup/settings.asciidoc b/docs/setup/settings.asciidoc index 7a21705336313..55128f213f356 100644 --- a/docs/setup/settings.asciidoc +++ b/docs/setup/settings.asciidoc @@ -22,7 +22,7 @@ you'll need to update your `kibana.yml` file. You can also enable SSL and set a `elasticsearch.customHeaders:`:: *Default: `{}`* Header names and values to send to Elasticsearch. Any custom headers cannot be overwritten by client-side headers, regardless of the `elasticsearch.requestHeadersWhitelist` configuration. -`elasticsearch.logQueries:`:: *Default: `false`* Logs queries sent to Elasticsearch. Requires `logging.verbose` set to `true`. This is useful for seeing the query DSL generated by applications that currently do not have a spy panel, for example Timelion and Monitoring. +`elasticsearch.logQueries:`:: *Default: `false`* Logs queries sent to Elasticsearch. Requires `logging.verbose` set to `true`. This is useful for seeing the query DSL generated by applications that currently do not have an inspector, for example Timelion and Monitoring. `elasticsearch.pingTimeout:`:: *Default: the value of the `elasticsearch.requestTimeout` setting* Time in milliseconds to wait for Elasticsearch to respond to pings. diff --git a/src/ui/public/inspector/types.ts b/src/ui/public/inspector/types.ts index ad613c4d043c9..668e9347cc56c 100644 --- a/src/ui/public/inspector/types.ts +++ b/src/ui/public/inspector/types.ts @@ -18,7 +18,7 @@ */ /** - * The interface that the adapters used to open spy panels have to fullfill. + * The interface that the adapters used to open an inspector have to fullfill. */ export interface Adapters { [key: string]: any; diff --git a/src/ui/public/vis/request_handlers/courier.js b/src/ui/public/vis/request_handlers/courier.js index 703314118db17..c365011a253fa 100644 --- a/src/ui/public/vis/request_handlers/courier.js +++ b/src/ui/public/vis/request_handlers/courier.js @@ -87,7 +87,7 @@ const CourierRequestHandlerProvider = function () { aggs.setTimeRange(timeRange); // For now we need to mirror the history of the passed search source, since - // the spy panel wouldn't work otherwise. + // the request inspector wouldn't work otherwise. Object.defineProperty(requestSearchSource, 'history', { get() { return searchSource.history; diff --git a/src/ui/public/visualize/loader/__tests__/visualize_loader.js b/src/ui/public/visualize/loader/__tests__/visualize_loader.js index de6bc0d29bb79..a13a993ed287e 100644 --- a/src/ui/public/visualize/loader/__tests__/visualize_loader.js +++ b/src/ui/public/visualize/loader/__tests__/visualize_loader.js @@ -185,12 +185,6 @@ describe('visualize loader', () => { expect(vis.attr('data-foo')).to.be(''); expect(vis.attr('data-with-dash')).to.be('value'); }); - - it('should hide spy panel control by default', () => { - const vis = embedWithParams({}); - expect(vis.find('[data-test-subj="spyToggleButton"]').length).to.be(0); - }); - }); describe('embedVisualizationWithId', () => { diff --git a/test/functional/apps/visualize/_tile_map.js b/test/functional/apps/visualize/_tile_map.js index 19e8ee4a3f3d5..3a5e19ee1500a 100644 --- a/test/functional/apps/visualize/_tile_map.js +++ b/test/functional/apps/visualize/_tile_map.js @@ -33,7 +33,6 @@ export default function ({ getService, getPageObjects }) { before(async function () { - // Make sure the window is height enough to show the spy panel without hiding the map remote.setWindowSize(1280, 1000); const fromTime = '2015-09-19 06:31:44.000'; @@ -64,7 +63,6 @@ export default function ({ getService, getPageObjects }) { describe('complete config', function describeIndexTests() { before(async function () { - // Make sure the window is height enough to show the spy panel without hiding the map remote.setWindowSize(1280, 1000); const fromTime = '2015-09-19 06:31:44.000';