[ML] File upload: Adds deployment initialization step #198446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
:ml
v9.0.0
v8.17.0
release_note:enhancement
Feature:File and Index Data Viz
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Nov 11, 2024
| } | ||
| if (dataViewCreatedStatus === IMPORT_STATUS.COMPLETE) { | ||
| completedStep = 5; | ||
| completedStep = 6; |
There was a problem hiding this comment.
To avoid bumping a completed step for each case in case of similar changes, did you consider defining them as a collection? name might be used for conditions later, without a need of bumping the index
interface ImportProgressStep {
name: string;
title: string; // Not sure if that would work, but we could also assign titles to each step
isCompleted: () => boolean; // or just assigning a boolean to the prop directly
}
const steps: ImportProgressStep = [
{
name: 'initStep',
isCompleted: () => reading === true &&
readStatus === IMPORT_STATUS.INCOMPLETE &&
parseJSONStatus === IMPORT_STATUS.INCOMPLETE
},
...
]There was a problem hiding this comment.
I agree having numbered steps here is not nice at all. This code is old and is going to be replaced in the upcoming file upload redesign. So I didn't want to get into refactoring it now.
...ata_visualizer/public/application/file_data_visualizer/components/import_view/auto_deploy.ts
Outdated
Show resolved
Hide resolved
...ata_visualizer/public/application/file_data_visualizer/components/import_view/auto_deploy.ts
Show resolved
Hide resolved
...ata_visualizer/public/application/file_data_visualizer/components/import_view/auto_deploy.ts
Outdated
Show resolved
Hide resolved
| path: '/internal/data_visualizer/inference/{inferenceId}', | ||
| access: 'internal', | ||
| options: { | ||
| tags: ['access:fileUpload:analyzeFile'], |
There was a problem hiding this comment.
do we need an additional tag for inference?
There was a problem hiding this comment.
I don't think it's needed as es will be checking permissions.
The tags here are just for feature enablement.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11794932613 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
Fixes elastic#196696 When adding a semantic text field, we now have an additional step in the file uploading process which calls inference for the selected inference endpoint. The response of the inference call is ignored and a poll is started to check to see of the model has been deployed by check to see if `num_allocations > 0` Any errors returned from the inference call will stop the upload, unless they are timeout errors which are ignored. https://github.com/user-attachments/assets/382ce565-3b4b-47a3-a081-d79c15aa462f (cherry picked from commit fa6d8ee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
#199741) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] File upload adding deployment initialization step (#198446)](#198446) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T10:02:26Z","message":"[ML] File upload adding deployment initialization step (#198446)\n\nFixes https://github.com/elastic/kibana/issues/196696\r\n\r\nWhen adding a semantic text field, we now have an additional step in the\r\nfile uploading process which calls inference for the selected inference\r\nendpoint.\r\nThe response of the inference call is ignored and a poll is started to\r\ncheck to see of the model has been deployed by check to see if\r\n`num_allocations > 0`\r\nAny errors returned from the inference call will stop the upload, unless\r\nthey are timeout errors which are ignored.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/382ce565-3b4b-47a3-a081-d79c15aa462f","sha":"fa6d8ee9e0f6fcaa0280fbf5ab60217f9f28279f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:File and Index Data Viz","Feature:File Upload","v9.0.0","backport:version","v8.17.0"],"title":"[ML] File upload adding deployment initialization step","number":198446,"url":"https://github.com/elastic/kibana/pull/198446","mergeCommit":{"message":"[ML] File upload adding deployment initialization step (#198446)\n\nFixes https://github.com/elastic/kibana/issues/196696\r\n\r\nWhen adding a semantic text field, we now have an additional step in the\r\nfile uploading process which calls inference for the selected inference\r\nendpoint.\r\nThe response of the inference call is ignored and a poll is started to\r\ncheck to see of the model has been deployed by check to see if\r\n`num_allocations > 0`\r\nAny errors returned from the inference call will stop the upload, unless\r\nthey are timeout errors which are ignored.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/382ce565-3b4b-47a3-a081-d79c15aa462f","sha":"fa6d8ee9e0f6fcaa0280fbf5ab60217f9f28279f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198446","number":198446,"mergeCommit":{"message":"[ML] File upload adding deployment initialization step (#198446)\n\nFixes https://github.com/elastic/kibana/issues/196696\r\n\r\nWhen adding a semantic text field, we now have an additional step in the\r\nfile uploading process which calls inference for the selected inference\r\nendpoint.\r\nThe response of the inference call is ignored and a poll is started to\r\ncheck to see of the model has been deployed by check to see if\r\n`num_allocations > 0`\r\nAny errors returned from the inference call will stop the upload, unless\r\nthey are timeout errors which are ignored.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/382ce565-3b4b-47a3-a081-d79c15aa462f","sha":"fa6d8ee9e0f6fcaa0280fbf5ab60217f9f28279f"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
Fixes elastic#196696 When adding a semantic text field, we now have an additional step in the file uploading process which calls inference for the selected inference endpoint. The response of the inference call is ignored and a poll is started to check to see of the model has been deployed by check to see if `num_allocations > 0` Any errors returned from the inference call will stop the upload, unless they are timeout errors which are ignored. https://github.com/user-attachments/assets/382ce565-3b4b-47a3-a081-d79c15aa462f
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Fixes elastic#196696 When adding a semantic text field, we now have an additional step in the file uploading process which calls inference for the selected inference endpoint. The response of the inference call is ignored and a poll is started to check to see of the model has been deployed by check to see if `num_allocations > 0` Any errors returned from the inference call will stop the upload, unless they are timeout errors which are ignored. https://github.com/user-attachments/assets/382ce565-3b4b-47a3-a081-d79c15aa462f
peteharverson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196696
When adding a semantic text field, we now have an additional step in the file uploading process which calls inference for the selected inference endpoint.
The response of the inference call is ignored and a poll is started to check to see of the model has been deployed by check to see if
num_allocations > 0Any errors returned from the inference call will stop the upload, unless they are timeout errors which are ignored.
2024-11-05.15-52-49.2024-11-05.15_53_40.mp4