From 328a60e7fa1aec8a9555918cb234bae8970deff6 Mon Sep 17 00:00:00 2001
From: Justin Kambic <justin.kambic@elastic.co>
Date: Tue, 5 Jun 2018 12:30:11 -0400
Subject: [PATCH] Remove dirty prompt from Logstash Pipeline Management
 (#19649)

* Remove dirty prompt from Logstash Pipeline management because of Angular routing issue.

* Remove test for removed feature.
---
 .../components/pipeline_edit/pipeline_edit.js      |  5 -----
 .../functional/apps/logstash/pipeline_create.js    | 14 --------------
 2 files changed, 19 deletions(-)

diff --git a/x-pack/plugins/logstash/public/sections/pipeline_edit/components/pipeline_edit/pipeline_edit.js b/x-pack/plugins/logstash/public/sections/pipeline_edit/components/pipeline_edit/pipeline_edit.js
index 9904486c48412e..57262c8889fb79 100644
--- a/x-pack/plugins/logstash/public/sections/pipeline_edit/components/pipeline_edit/pipeline_edit.js
+++ b/x-pack/plugins/logstash/public/sections/pipeline_edit/components/pipeline_edit/pipeline_edit.js
@@ -8,7 +8,6 @@ import { isEmpty } from 'lodash';
 import { uiModules } from 'ui/modules';
 import { InitAfterBindingsWorkaround } from 'ui/compat';
 import { Notifier, toastNotifications } from 'ui/notify';
-import 'ui/dirty_prompt';
 import template from './pipeline_edit.html';
 import 'plugins/logstash/services/license';
 import 'plugins/logstash/services/security';
@@ -25,7 +24,6 @@ app.directive('pipelineEdit', function ($injector) {
   const securityService = $injector.get('logstashSecurityService');
   const kbnUrl = $injector.get('kbnUrl');
   const confirmModal = $injector.get('confirmModal');
-  const dirtyPrompt = $injector.get('dirtyPrompt');
 
   return {
     restrict: 'E',
@@ -62,8 +60,6 @@ app.directive('pipelineEdit', function ($injector) {
 
         this.tooltips = TOOLTIPS;
 
-        dirtyPrompt.register(() => !this.pipeline.isEqualTo(this.originalPipeline));
-        $scope.$on('$destroy', dirtyPrompt.deregister);
       }
 
       onPipelineSave = (username) => {
@@ -105,7 +101,6 @@ app.directive('pipelineEdit', function ($injector) {
       }
 
       close = () => {
-        dirtyPrompt.deregister();
         kbnUrl.change('/management/logstash/pipelines', {});
       }
 
diff --git a/x-pack/test/functional/apps/logstash/pipeline_create.js b/x-pack/test/functional/apps/logstash/pipeline_create.js
index 95f7756e27fdf5..4b855b1238de0f 100644
--- a/x-pack/test/functional/apps/logstash/pipeline_create.js
+++ b/x-pack/test/functional/apps/logstash/pipeline_create.js
@@ -13,7 +13,6 @@ export default function ({ getService, getPageObjects }) {
   const pipelineList = getService('pipelineList');
   const pipelineEditor = getService('pipelineEditor');
   const PageObjects = getPageObjects(['logstash']);
-  const testSubjects = getService('testSubjects');
 
   describe('pipeline create new', () => {
     let originalWindowSize;
@@ -94,18 +93,5 @@ export default function ({ getService, getPageObjects }) {
         await pipelineEditor.assertNoDeleteButton();
       });
     });
-
-    describe('breadcrumbs navigation', () => {
-      it('prompts the user about unsaved changes', async () => {
-        await PageObjects.logstash.gotoNewPipelineEditor();
-
-        const description = random.text();
-        await pipelineEditor.setDescription(description);
-
-        await pipelineEditor.clickManagementBreadcrumb();
-        await pipelineEditor.assertUnsavedChangesModal();
-        await testSubjects.click('confirmModalConfirmButton');
-      });
-    });
   });
 }