Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] [Onboarding] Update document count #196674

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

joemcelroy
Copy link
Member

@joemcelroy joemcelroy commented Oct 17, 2024

Summary

This uses the document list count within the quick stats. Before it used the document count from es3 billing and takes a while to update.

Screen.Recording.2024-10-17.at.12.38.01.mov

Checklist

Delete any items that are not applicable to this PR.

@joemcelroy joemcelroy requested a review from a team as a code owner October 17, 2024 11:39
@joemcelroy joemcelroy added Team:Search backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Oct 17, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7163

[✅] x-pack/test_serverless/api_integration/test_suites/search/config.feature_flags.ts: 25/25 tests passed.

see run history

@joemcelroy
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-index-documents 33 34 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 159.1KB 159.3KB +170.0B
Unknown metric groups

API count

id before after diff
@kbn/search-index-documents 35 36 +1

@joemcelroy joemcelroy merged commit 5c51e78 into elastic:main Oct 22, 2024
22 checks passed
@joemcelroy joemcelroy deleted the update-document-count branch October 22, 2024 10:10
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11457999127

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2024
## Summary

This uses the document list count within the quick stats. Before it used
the document count from es3 billing and takes a while to update.

https://github.com/user-attachments/assets/9c29c88a-628f-4c63-99e5-d892a835e973

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 5c51e78)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 22, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search] [Onboarding] Update document count
(#196674)](#196674)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T10:10:47Z","message":"[Search]
[Onboarding] Update document count (#196674)\n\n## Summary\r\n\r\nThis
uses the document list count within the quick stats. Before it
used\r\nthe document count from es3 billing and takes a while to
update.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9c29c88a-628f-4c63-99e5-d892a835e973\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"5c51e783e5aee29bae1087403b75e2236b9ec0e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Search]
[Onboarding] Update document
count","number":196674,"url":"https://github.com/elastic/kibana/pull/196674","mergeCommit":{"message":"[Search]
[Onboarding] Update document count (#196674)\n\n## Summary\r\n\r\nThis
uses the document list count within the quick stats. Before it
used\r\nthe document count from es3 billing and takes a while to
update.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9c29c88a-628f-4c63-99e5-d892a835e973\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"5c51e783e5aee29bae1087403b75e2236b9ec0e8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196674","number":196674,"mergeCommit":{"message":"[Search]
[Onboarding] Update document count (#196674)\n\n## Summary\r\n\r\nThis
uses the document list count within the quick stats. Before it
used\r\nthe document count from es3 billing and takes a while to
update.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/9c29c88a-628f-4c63-99e5-d892a835e973\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"5c51e783e5aee29bae1087403b75e2236b9ec0e8"}}]}]
BACKPORT-->

Co-authored-by: Joe McElroy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants