From edb7a0b7f19fcc9af472a06e3da6d1f221726154 Mon Sep 17 00:00:00 2001
From: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
Date: Thu, 17 Oct 2024 13:13:09 +0200
Subject: [PATCH] [TSVB] fix incomplete string escaping or encoding (#196248)

## Summary

Fixes incomplete string escaping or encoding for TSVB.

(cherry picked from commit 7c4a83d4c920b5bc35b88ffc0460c139bb0d846b)
---
 .../public/convert_to_lens/lib/convert/cumulative_sum.ts      | 2 +-
 .../timeseries/public/convert_to_lens/lib/convert/formula.ts  | 4 ++--
 .../public/convert_to_lens/lib/convert/parent_pipeline.ts     | 2 +-
 .../convert_to_lens/lib/metrics/filter_ratio_formula.ts       | 2 +-
 .../public/convert_to_lens/lib/metrics/metrics_helpers.ts     | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/cumulative_sum.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/cumulative_sum.ts
index 9a119016353a9..8e2a34505974c 100644
--- a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/cumulative_sum.ts
+++ b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/cumulative_sum.ts
@@ -32,7 +32,7 @@ export const convertToCumulativeSumColumns = (
   // lens supports cumulative sum for count and sum as quick function
   // and everything else as formula
   if (subFunctionMetric.type !== 'count' && pipelineAgg.name !== 'sum') {
-    const metaValue = Number(meta?.replace(']', ''));
+    const metaValue = Number(meta?.replace(/\]/g, ''));
     formula = getPipelineSeriesFormula(metric, metrics, subFunctionMetric, {
       metaValue,
       reducedTimeRange,
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/formula.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/formula.ts
index 0f6b54a74c03b..2944538b15e9c 100644
--- a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/formula.ts
+++ b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/formula.ts
@@ -65,7 +65,7 @@ const convertFormulaScriptForPercentileAggs = (
 ) => {
   variables.forEach((variable) => {
     const [_, meta] = variable?.field?.split('[') ?? [];
-    const metaValue = Number(meta?.replace(']', ''));
+    const metaValue = Number(meta?.replace(/\]/g, ''));
     if (!metaValue) {
       return;
     }
@@ -162,7 +162,7 @@ export const convertOtherAggsToFormulaColumn = (
   const metric = metrics[metrics.length - 1];
   const [fieldId, meta] = metric?.field?.split('[') ?? [];
   const subFunctionMetric = metrics.find(({ id }) => id === fieldId);
-  const metaValue = meta ? Number(meta?.replace(']', '')) : undefined;
+  const metaValue = meta ? Number(meta?.replace(/\]/g, '')) : undefined;
 
   if (!subFunctionMetric) {
     return null;
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/parent_pipeline.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/parent_pipeline.ts
index 900d1486c4f17..6edf5994e4418 100644
--- a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/parent_pipeline.ts
+++ b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/convert/parent_pipeline.ts
@@ -234,7 +234,7 @@ const convertMovingAvgOrDerivativeToColumns = (
   if (!pipelineAgg) {
     return null;
   }
-  const metaValue = Number(meta?.replace(']', ''));
+  const metaValue = Number(meta?.replace(/\]/g, ''));
   const subMetricField = subFunctionMetric.field;
   const [nestedFieldId, _] = subMetricField?.split('[') ?? [];
   // support nested aggs with formula
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/filter_ratio_formula.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/filter_ratio_formula.ts
index bcbd80fc1a26b..013217a0a5e73 100644
--- a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/filter_ratio_formula.ts
+++ b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/filter_ratio_formula.ts
@@ -13,7 +13,7 @@ import { addAdditionalArgs } from '.';
 import { AdditionalArgs } from '../../types';
 
 const escapeQuotes = (str: string) => {
-  return str?.replace(/'/g, "\\'");
+  return str?.replace(/\\/g, '\\\\').replace(/'/g, "\\'");
 };
 
 const constructFilterRationFormula = (
diff --git a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/metrics_helpers.ts b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/metrics_helpers.ts
index 4b679d0dd0d15..303e80963c797 100644
--- a/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/metrics_helpers.ts
+++ b/src/plugins/vis_types/timeseries/public/convert_to_lens/lib/metrics/metrics_helpers.ts
@@ -112,7 +112,7 @@ export const getFormulaEquivalent = (
       }
 
       return getPipelineSeriesFormula(currentMetric, metrics, subFunctionMetric, {
-        metaValue: nestedMetaValue ? Number(nestedMetaValue?.replace(']', '')) : undefined,
+        metaValue: nestedMetaValue ? Number(nestedMetaValue?.replace(/\]/g, '')) : undefined,
         reducedTimeRange,
         timeShift,
       });