-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Display outputs in agent list table and agent details #195801
[Fleet] Display outputs in agent list table and agent details #195801
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/fleet (Team:Fleet) |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this work is not complete yet. With #189125, each integration can set their own output, so I expect the Output for integrations
to be the unique sum of all outputs used by the agent policy's integrations, plus the default one set on the agent policy (or global default if unset).
We should be careful about how we retrieve this "deep" association. Perhaps we should either return all outputs used to the agent policy info GET endpoint, or add a separate endpoint specifically to return outputs for a given agent policy ID.
...fleet/sections/agents/agent_details_page/components/agent_details/agent_details_overview.tsx
Outdated
Show resolved
Hide resolved
...fleet/sections/agents/agent_details_page/components/agent_details/agent_details_overview.tsx
Outdated
Show resolved
Hide resolved
...plications/fleet/sections/agents/agent_list_page/components/agent_policy_outputs_summary.tsx
Outdated
Show resolved
Hide resolved
...plications/fleet/sections/agents/agent_list_page/components/agent_policy_outputs_summary.tsx
Outdated
Show resolved
Hide resolved
...et/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
@jen-huang thanks for pointing it out. I previously missed this piece, so I put back the PR to draft to keep working on it
I'm currently working on implementing a new endpoint under
My idea is to use this endpoint to retrieve only this information instead of adding it under the existing agent policies The response in this case is
But I'm thinking to return also the name for each output under |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
cc @criamico |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11462875221 |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11462875155 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Closes #192339
Summary
Display two additional columns with Outputs hosts in agent list table and agent details section
To achieve this, I added two new endpoints.
The reason to pass an array of ids is to ensure that we fetch the info only for the policies displayed in the table at any given moment.
Screenshots
Agent list
Agent details
Checklist
For maintainers