Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Notes] - limit visible text from note content on notes management page #195296

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Security Solution][Notes] - limit visible text from note content on notes management page #195296

merged 2 commits into from
Oct 9, 2024

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Oct 7, 2024 •
edited by kibanamachine
Loading

Summary

This PR makes a small modification to the Notes management page, to truncate the note content in the table, and allow users to click on the text to reveal the entire content in a popover.

Screen.Recording.2024-10-09.at.5.03.29.PM.mov

Checklist

#193090

@PhilippeOberti PhilippeOberti added backport release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 labels Oct 7, 2024
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner October 7, 2024 16:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti force-pushed the note-management-content branch from 830a8d9 to 4c85e3a Compare October 8, 2024 20:15
christineweng
christineweng reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@christineweng christineweng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me. some desk testing findings:

  1. if the content goes beyond the space of the tooltip, the position changes and hides come texts
    image
    I was going to suggest clipping the text instead, but it seems currently there is no way to access the notes in note list?

  2. nit: when adding a new note with the notes page in the background. the note first show up at the bottom, and upon refresh goes to the top

Screen.Recording.2024-10-09.at.10.40.43.AM.mov

@christineweng christineweng mentioned this pull request Oct 9, 2024
Merged
2 tasks
@PhilippeOberti PhilippeOberti force-pushed the note-management-content branch from 4c85e3a to f2a2fcf Compare October 9, 2024 22:04
@PhilippeOberti
Copy link
Contributor Author

code looks good to me. some desk testing findings:

  1. if the content goes beyond the space of the tooltip, the position changes and hides come texts

good point, this second commit makes sure that the popover width and height will never be more than 50% of the screen, which I think look nice. The popover has now it's content scrollable.
I updated the PR description with the new video, let me know what you think!

  1. nit: when adding a new note with the notes page in the background. the note first show up at the bottom, and upon refresh goes to the top

I will take a look at that separately!

christineweng
christineweng approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New UI looks great! 🚀🚀

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / Serverless Common UI - Management Index Management Indices can delete index

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5928 5929 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB +5.4KB

History

  • 💚 Build #240443 succeeded 4c85e3a9df00346d8d36473f89bca55cf7e64ec3
  • 💚 Build #239970 succeeded 830a8d97a0fcb943b865de7ff1948c0edad2f8f7

@PhilippeOberti PhilippeOberti merged commit 69ff471 into elastic:main Oct 9, 2024
41 checks passed
@PhilippeOberti PhilippeOberti deleted the note-management-content branch October 9, 2024 23:49
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11264815716

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@PhilippeOberti
[Security Solution][Notes] - limit visible text from note content on …
2f02ed3 
…notes management page (elastic#195296)

(cherry picked from commit 69ff471)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
@kibanamachine @PhilippeOberti
[8.x] [Security Solution][Notes] - limit visible text from note conte…
090c150 
…nt on notes management page (#195296) (#195692)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Notes] - limit visible text from note content on
notes management page
(#195296)](#195296)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T23:49:36Z","message":"[Security
Solution][Notes] - limit visible text from note content on notes
management page
(#195296)","sha":"69ff471983a543c3052923e6b05385460079e45e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] -
limit visible text from note content on notes management
page","number":195296,"url":"https://github.com/elastic/kibana/pull/195296","mergeCommit":{"message":"[Security
Solution][Notes] - limit visible text from note content on notes
management page
(#195296)","sha":"69ff471983a543c3052923e6b05385460079e45e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195296","number":195296,"mergeCommit":{"message":"[Security
Solution][Notes] - limit visible text from note content on notes
management page
(#195296)","sha":"69ff471983a543c3052923e6b05385460079e45e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christineweng christineweng christineweng approved these changes

Assignees
No one assigned
Labels
backport release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PhilippeOberti @elasticmachine @kibanamachine @christineweng