Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature flag for manual rule run #193833

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Remove feature flag for manual rule run #193833

merged 9 commits into from
Oct 9, 2024

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Sep 24, 2024 •
edited by kibanamachine
Loading

Summary

Remove feature flag for manual rule run

@nkhristinin nkhristinin requested review from a team as code owners September 24, 2024 08:56
@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Sep 24, 2024
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

dplumlee
dplumlee approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule management changes lgtm

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

rylnd
rylnd approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some additional comments that can/should be deleted, here, but otherwise LGTM!

...etections_response/detection_engine/rule_gaps/trial_license_complete_tier/manual_rule_run.ts
@@ -43,8 +43,7 @@ export default ({ getService }: FtrProviderContext) => {
const es = getService('es');

// Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments.
// Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment line before this one can also be removed.

...ity_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_edit/preview.cy.ts
@@ -33,8 +33,7 @@ describe(
'Detection rules, preview',
{
// Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments.
// Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment line before this one can also be removed.

...cypress/cypress/e2e/detection_response/detection_engine/rule_gaps/bulk_manual_rule_run.cy.ts
@@ -20,8 +20,7 @@ import { createRule } from '../../../../tasks/api_calls/rules';
import { login } from '../../../../tasks/login';

// Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments.
// Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment line before this one can also be removed.

...tion_cypress/cypress/e2e/detection_response/detection_engine/rule_gaps/manual_rule_run.cy.ts
@@ -19,8 +19,7 @@ import { createRule } from '../../../../tasks/api_calls/rules';
import { login } from '../../../../tasks/login';

// Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments.
// Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment line before this one can also be removed.

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 7, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / ExecutionLogSearchBar snapshots renders correctly against snapshot
  • [job] [logs] Jest Tests #9 / ExecutionLogSearchBar snapshots renders correctly against snapshot

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB -689.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.3KB 88.3KB -24.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MadameSheema
MadameSheema approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sec-eng-prod changes LGTM!!

Please check if any of the tests meet the criteria to be added to the Kibana QA quality gate. Thanks!

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin enabled auto-merge (squash) October 9, 2024 14:57
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 9, 2024 •
edited
Loading

⏳ Build in-progress

History

@nkhristinin nkhristinin merged commit 3f75a1d into elastic:main Oct 9, 2024
45 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11259960947

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
@nkhristinin
Remove feature flag for manual rule run (elastic#193833)
89040c3 
## Summary

Remove feature flag for manual rule run

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 3f75a1d)
@kibanamachine kibanamachine mentioned this pull request Oct 9, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
@kibanamachine @nkhristinin
[8.x] Remove feature flag for manual rule run (#193833) (#195657)
abd6766 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove feature flag for manual rule run
(#193833)](#193833)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T17:23:46Z","message":"Remove
feature flag for manual rule run (#193833)\n\n## Summary\r\n\r\nRemove
feature flag for manual rule run\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"3f75a1d3d56e1d2c84ed0d4c5b18b3beb8357d3b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:cloud-deploy","ci:cloud-persist-deployment","ci:project-deploy-security"],"title":"Remove
feature flag for manual rule
run","number":193833,"url":"https://github.com/elastic/kibana/pull/193833","mergeCommit":{"message":"Remove
feature flag for manual rule run (#193833)\n\n## Summary\r\n\r\nRemove
feature flag for manual rule run\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"3f75a1d3d56e1d2c84ed0d4c5b18b3beb8357d3b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193833","number":193833,"mergeCommit":{"message":"Remove
feature flag for manual rule run (#193833)\n\n## Summary\r\n\r\nRemove
feature flag for manual rule run\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"3f75a1d3d56e1d2c84ed0d4c5b18b3beb8357d3b"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <[email protected]>
@maximpn maximpn mentioned this pull request Oct 10, 2024
Merged
@nastasha-solomon nastasha-solomon mentioned this pull request Oct 14, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplumlee dplumlee dplumlee approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

@rylnd rylnd rylnd approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nkhristinin @kibana-ci @elasticmachine @kibanamachine @rylnd @MadameSheema @dplumlee