[Embeddable Rebuild] [Discover] Fix bundle size #189206
Conversation
Heenawter
added
Team:Presentation
Heenawter
force-pushed
the
embeddableRebuild_fixDiscoverBundleSize_2024-07-25
branch
from
a1c0bac to
d107fac
Compare
|
/ci |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
| const { apiCanAccessViewMode, apiHasType, apiIsOfType, getInheritedViewMode } = await import( | ||
| '@kbn/presentation-publishing' | ||
| ); |
There was a problem hiding this comment.
One downside to this approach is that I think our async bundle will now grow with @kbn/presentation-publishing since we're importing the entire package here. I wonder if it would work to keep the imports how they were for tree shaking, but break getCompatibilityCheck out into a separate file and async import that here instead?
There was a problem hiding this comment.
Oh!! Genius 🤯 Good call on that one - did this in 5080816 and it reduced the async bundle size increase of this PR by about 50% (I think it was around +12KB before, and it's +6KB now).
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @Heenawter |
kibanamachine
added
v8.16.0
backport:skip
…189533) #189128 increases @kbn/presentation-containers size. This causes synthetics page load bundle to exceed the bundle size limit. Synthetics page load should not include @kbn/presentation-containers. This PR resolves the problem by putting @kbn/presentation-containers load behind an async import Note for reviewers, put compatibility check into its own file to avoid importing entire @kbn/presentation-containers into async bundle. Tree shaking is enable by putting the import in a seperate file - see #189206 (comment) for more details
Summary
This PR is a follow up to #180536, where
8.8KBwas added to the Discover bundle size - now, after async importing from thepresentation-publishingpackage where necessary, I've reduced that increase to3.4KB(a decrease of5.4KBfrom the previous PR).For maintainers