Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove job_type from job definitions in modules 7.17 #179600

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[ML] Remove job_type from job definitions in modules 7.17 #179600

merged 2 commits into from
Mar 28, 2024

Conversation

jgowdyelastic
Copy link
Member

Manual back port of #149247
Fixes #179169

@jgowdyelastic
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] OSS CI Group #2 / index pattern field editor example index pattern field editor example finds an index pattern

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 939.9KB 939.7KB -180.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic self-assigned this Mar 28, 2024
@jgowdyelastic jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v7.17.20 labels Mar 28, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review March 28, 2024 17:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 53946dd into elastic:7.17 Mar 28, 2024
32 checks passed
@jgowdyelastic jgowdyelastic deleted the remove-job_type-from-job-definitions-in-modules branch March 28, 2024 18:40
@jgowdyelastic jgowdyelastic mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.17.20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @kibana-ci @elasticmachine @peteharverson @qn895