[Cloud Security] [Posture Dashboard] Update links to the findings page with groupBy option #176463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opauloh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
JordanSh
approved these changes
Feb 8, 2024
Comment on lines
21
to
+43
| type: CIS_AWS, | ||
| name: 'Amazon Web Services (AWS)', | ||
| provider: 'aws', | ||
| name: getBenchmarkApplicableTo(CIS_AWS), | ||
| provider: CLOUD_PROVIDERS.AWS, | ||
| }, | ||
| { | ||
| type: CIS_GCP, | ||
| name: 'Google Cloud Platform (GCP)', | ||
| provider: 'gcp', | ||
| name: getBenchmarkApplicableTo(CIS_GCP), | ||
| provider: CLOUD_PROVIDERS.GCP, | ||
| }, | ||
| { | ||
| type: CIS_AZURE, | ||
| name: 'Azure', | ||
| provider: 'azure', | ||
| name: getBenchmarkApplicableTo(CIS_AZURE), | ||
| provider: CLOUD_PROVIDERS.AZURE, | ||
| }, | ||
| { | ||
| type: CIS_K8S, | ||
| name: 'Kubernetes', | ||
| benchmarkId: 'cis_k8s', | ||
| name: getBenchmarkApplicableTo(CIS_K8S), | ||
| benchmarkId: CIS_K8S, | ||
| }, | ||
| { | ||
| type: CIS_EKS, | ||
| name: 'Amazon Elastic Kubernetes Service (EKS)', | ||
| benchmarkId: 'cis_eks', | ||
| name: getBenchmarkApplicableTo(CIS_EKS), | ||
| benchmarkId: CIS_EKS, |
There was a problem hiding this comment.
i see that its not new, but can we change it so all of those uses benchmarkId to keep it consistent? not urgent
Comment on lines
+82
to
+85
| return navToFindingsByCloudProvider(benchmark.provider); | ||
| } | ||
| if (benchmark.benchmarkId) { | ||
| navToFindingsByCisBenchmark(benchmark.benchmarkId); | ||
| return navToFindingsByCisBenchmark(benchmark.benchmarkId); |
There was a problem hiding this comment.
why do we need to return here? no one takes in the value and the functions themselves do not return anything. i think this is redundant.
| @@ -57,7 +57,7 @@ const useNavigate = (pathname: string, dataViewId = SECURITY_DEFAULT_DATA_VIEW_I | |||
| const { services } = useKibana(); | |||
|
|
|||
| return useCallback( | |||
| (filterParams: NavFilter = {}) => { | |||
| (filterParams: NavFilter = {}, groupBy?: string[]) => { | |||
There was a problem hiding this comment.
might be to read and use if this function will receive an object, not urgent since it will require some refactoring
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…e with groupBy option (elastic#176463)
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…e with groupBy option (elastic#176463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #173496
This PR updates the Cloud Posture Dashboard links to the findings page to leverage the new Grouping visualization.
Account Evaluated section links and Benchmarks on the Cloud Tab redirect to the Findings page Grouped by Cloud Account.
Account Evaluated section links and Benchmarks on the Kubernetes Tab redirect to the Findings page Grouped by Kubernetes Cluster.
Recording
Cloud Tab
Screen.Recording.2024-02-07.at.5.43.00.PM.mov
Kubernetes Tab
Screen.Recording.2024-02-07.at.5.43.27.PM.mov