[Search] Use Connector API for update_service_type #176306
Conversation
jedrazb
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
|
||
| export const updateConnectorServiceType = async ( | ||
| client: ElasticsearchClient, | ||
| connectorId: string, | ||
| serviceType: string | ||
| ) => { | ||
| const connectorResult = await fetchConnectorById(client, connectorId); | ||
|
|
||
| if (connectorResult?.value) { |
There was a problem hiding this comment.
Is it no longer necessary to confirm the connector doc exists first?
There was a problem hiding this comment.
Correct, if document doesn't exist we return 404 from Connector API.
In status quo the check makes sure that we don't write partial update to the index directly.
There was a problem hiding this comment.
It shouldn't be, it's fine if this errors out if the connector has been deleted. The only reason we're checking there is so we wouldn't have to do null checks inside the if block and can spread the value easily.
|
|
||
| export const updateConnectorServiceType = async ( | ||
| client: ElasticsearchClient, | ||
| connectorId: string, | ||
| serviceType: string | ||
| ) => { | ||
| const connectorResult = await fetchConnectorById(client, connectorId); | ||
|
|
||
| if (connectorResult?.value) { |
There was a problem hiding this comment.
It shouldn't be, it's fine if this errors out if the connector has been deleted. The only reason we're checking there is so we wouldn't have to do null checks inside the if block and can spread the value easily.
## Summary Use connectors API for update service type operation
## Summary Use connectors API for update service type operation
## Summary Use connectors API for update service type operation
Summary
Use connectors API for update service type operation, it includes 2 actions:
Added unit tests. Also tested manually in serverless (this action is only used in serverless):
search-xdindexsharepoint_onlineand update the connector config with new service type (everything else remains unchanged)Checklist