From 83c601990ba0215415286f97a15e95e5b50eeb31 Mon Sep 17 00:00:00 2001 From: Gerard Soldevila Date: Wed, 25 Oct 2023 17:40:25 +0200 Subject: [PATCH] Add a slight delay before selecting a visualization type --- test/functional/page_objects/visualize_page.ts | 5 +++++ .../functional/tests/visualize_integration.ts | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/test/functional/page_objects/visualize_page.ts b/test/functional/page_objects/visualize_page.ts index 55abacfec4009..e39c9ac3a679d 100644 --- a/test/functional/page_objects/visualize_page.ts +++ b/test/functional/page_objects/visualize_page.ts @@ -170,6 +170,11 @@ export class VisualizePageObject extends FtrService { } public async clickVisType(type: string) { + // checking for the existence of the control gives the UI more time to bind a click handler + // see https://github.com/elastic/kibana/issues/89958 + if (!(await this.hasVisType(type))) { + throw new Error(`The '${type}' visualization type does not exist (visType-${type})`); + } await this.testSubjects.click(`visType-${type}`); await this.header.waitUntilLoadingHasFinished(); } diff --git a/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts b/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts index b930818a9c500..a7a03a58ba0cf 100644 --- a/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts +++ b/x-pack/test/saved_object_tagging/functional/tests/visualize_integration.ts @@ -123,8 +123,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { }); }); - // FLAKY: https://github.com/elastic/kibana/issues/89958 - describe.skip('creating', () => { + describe('creating', () => { before(async () => { await PageObjects.visualize.gotoVisualizationLandingPage(); // delete all visualizations to create new ones explicitly