-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Introduce custom dashboards tab in service overview #166789
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
x-pack/plugins/apm/public/components/app/service_dashboards/actions/save_dashboard_modal.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_dashboards/actions/save_dashboard_modal.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_dashboards/actions/save_dashboard_modal.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_dashboards/actions/save_dashboard_modal.tsx
Show resolved
Hide resolved
savedObjectsClient: SavedObjectsClientContract; | ||
} | ||
|
||
export async function getLinkedCustomDashboards({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is there such a thing as a "linked custom dashboard"? Or is it merely a linked dashboard? Or a custom dashboard? Or just a dashboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, since I did the renaming I believe this needs to change to getCustomDashboards
to avoid confusion. WDYT?
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Saved Objects .kibana field count
Unknown metric groupsAPI count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
closes: #163590
Screen.Recording.2023-09-25.at.17.10.33.mov
Notes
[UPDATED] Fetch dynamically from the dashboard module api
service.environment
. Please see the changes tox-pack/plugins/apm/public/components/app/metrics/static_dashboard/index.tsx
TODO