Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Introduce custom dashboards tab in service overview #166789

Merged
merged 76 commits into from
Oct 3, 2023

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Sep 20, 2023

Summary

closes: #163590

Screen.Recording.2023-09-25.at.17.10.33.mov

Notes

  1. ~~Storing the dashboard name in the saved object may become outdated and cause confusion, as users have the ability to update the dashboard title on the dashboard page.
    [UPDATED] Fetch dynamically from the dashboard module api
  2. UI we don't have an indicator useContextFilter
  3. This fixes a bug related to service.environment. Please see the changes to x-pack/plugins/apm/public/components/app/metrics/static_dashboard/index.tsx

TODO

  • API tests
  • Dynamic title
  • Deep-link for dashboard
  • Fetch services that match the dashboard kuery

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha changed the title [APM] 163590 dashboard [APM] Customs dashboard Sep 20, 2023
@kpatticha kpatticha changed the title [APM] Customs dashboard [APM] Custom dashboard Sep 20, 2023
@kpatticha kpatticha requested a review from sorenlouv October 2, 2023 11:34
savedObjectsClient: SavedObjectsClientContract;
}

export async function getLinkedCustomDashboards({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is there such a thing as a "linked custom dashboard"? Or is it merely a linked dashboard? Or a custom dashboard? Or just a dashboard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, since I did the renaming I believe this needs to change to getCustomDashboards to avoid confusion. WDYT?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1489 1505 +16
securitySolution 4628 4630 +2
total +18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/shared-svg 2 4 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB +13.4KB
securitySolution 13.0MB 13.0MB +318.0B
total +13.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
apm 119 120 +1

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
apm-custom-dashboards - 5 +5
Unknown metric groups

API count

id before after diff
@kbn/shared-svg 2 4 +2

ESLint disabled line counts

id before after diff
apm 74 76 +2

miscellaneous assets size

id before after diff
apm 961.5KB 1.2MB ⚠️ +289.6KB
securitySolution 1.8MB 2.1MB ⚠️ +289.6KB
total +579.3KB

Total ESLint disabled count

id before after diff
apm 88 90 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha merged commit 17f633c into elastic:main Oct 3, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Implement a dedicated tab for custom dashboards
7 participants